From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ecos-discuss-return-31975-listarch-ecos-discuss=sources.redhat.com@ecos.sourceware.org>
Received: (qmail 22344 invoked by alias); 20 Jun 2005 10:12:53 -0000
Mailing-List: contact ecos-discuss-help@ecos.sourceware.org; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:ecos-discuss-subscribe@ecos.sourceware.org>
List-Archive: <http://ecos.sourceware.org/ml/ecos-discuss/>
List-Post: <mailto:ecos-discuss@ecos.sourceware.org>
List-Help: <mailto:ecos-discuss-help@ecos.sourceware.org>, <http://ecos.sourceware.org/ml/#faqs>
Sender: ecos-discuss-owner@ecos.sourceware.org
Received: (qmail 22315 invoked by uid 22791); 20 Jun 2005 10:12:46 -0000
Received: from prix.tandberg.no (HELO prix.tandberg.no) (194.196.35.10)
    by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Mon, 20 Jun 2005 10:12:46 +0000
Received: from 47mail.eu.tandberg.int (47mail.eu.tandberg.int [10.0.0.25])
	by prix.tandberg.no (8.12.10/8.12.10) with ESMTP id j5KACg4n008273;
	Mon, 20 Jun 2005 12:12:42 +0200
Received: from EXMAIL.eu.tandberg.int ([194.196.35.11]) by 47mail.eu.tandberg.int with Microsoft SMTPSVC(6.0.3790.1830);
	 Mon, 20 Jun 2005 12:12:42 +0200
Received: from [10.47.14.177] ([10.47.14.177]) by EXMAIL.eu.tandberg.int with Microsoft SMTPSVC(5.0.2195.6713);
	 Mon, 20 Jun 2005 12:12:39 +0200
Message-ID: <42B6969A.4060305@tandberg.net>
Date: Mon, 20 Jun 2005 10:12:00 -0000
From: Sturle Mastberg <sturle.mastberg@tandberg.net>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.2) Gecko/20040803
MIME-Version: 1.0
To: Arnaud Chataignier <achataignier@neotion.com>
CC: "'Gary Thomas'" <gary@mlbassoc.com>,
        "'Nick Garnett'" <nickg@ecoscentric.com>,
        "'Andrew Lunn'" <andrew@lunn.ch>,
        "'eCos Discussion'" <ecos-discuss@ecos.sourceware.org>
References: <001001c57577$1c629d30$140032be@ArnaudC>
In-Reply-To: <001001c57577$1c629d30$140032be@ArnaudC>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [ECOS] Re: RE : [ECOS] Possible fix for duplicated ARP entries in the FreeBSDstack
X-SW-Source: 2005-06/txt/msg00167.txt.bz2

Arnaud Chataignier wrote:
> Thank you all for the analysis. I was encountering this bug from a long
> time now, and fixing it is great news for me.
> 
> One person did post a temporary patch to this problem a long time ago,
> but it didn't seem to really correct the cause of the problem, it was
> just avoiding it :
> http://sourceware.org/ml/ecos-discuss/2004-11/msg00150.html
> 
> May anyone post a patch corresponding to this real correction ? As far
> as I understand, it is only a matter of changing the size of the sa_data
> member back to 14 ?

No, the increase in size of the sa_data member was apparently needed for 
IPv6. The fix is as I stated first: the sockaddr_inarp struct must be 
padded to match the size of the sockaddr struct. This can be done by 
adding a sin_zero member at the end of this struct, defined in 
include/netinet/if_ether.h. Like this:

struct sockaddr_inarp {
   u_char  sin_len;
   u_char  sin_family;
   u_short sin_port;
   struct  in_addr sin_addr;
   struct  in_addr sin_srcaddr;
   u_short sin_tos;
   u_short sin_other;
   char    sin_zero[16];
#define SIN_PROXY 1
};

Regards,
SM

-- 
Before posting, please read the FAQ: http://ecos.sourceware.org/fom/ecos
and search the list archive: http://ecos.sourceware.org/ml/ecos-discuss