From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14784 invoked by alias); 26 Jul 2005 17:25:15 -0000 Mailing-List: contact ecos-discuss-help@ecos.sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: ecos-discuss-owner@ecos.sourceware.org Received: (qmail 14734 invoked by uid 22791); 26 Jul 2005 17:25:11 -0000 Received: from norbert.ecoscentric.com (HELO smtp.ecoscentric.com) (194.153.168.165) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Tue, 26 Jul 2005 17:25:11 +0000 Received: by smtp.ecoscentric.com (Postfix, from userid 99) id A43E065C082; Tue, 26 Jul 2005 18:25:09 +0100 (BST) Received: from [127.0.0.1] (localhost [127.0.0.1]) by smtp.ecoscentric.com (Postfix) with ESMTP id 6246965C065; Tue, 26 Jul 2005 18:25:06 +0100 (BST) Message-ID: <42E671F1.4030801@eCosCentric.com> Date: Tue, 26 Jul 2005 17:25:00 -0000 From: Jonathan Larmour User-Agent: Mozilla Thunderbird 1.0.6-1.1.fc3 (X11/20050720) MIME-Version: 1.0 To: Andrew Lunn Cc: ecos-discuss@sources.redhat.com References: <80B97DE95AEED311BA580050047FE98403259494@mail.systech.com> <20050721180158.GK29741@lunn.ch> In-Reply-To: <20050721180158.GK29741@lunn.ch> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [ECOS] Termios memory leak? X-SW-Source: 2005-07/txt/msg00286.txt.bz2 Andrew Lunn wrote: > On Mon, Jul 18, 2005 at 09:29:25AM -0700, Jay Foster wrote: > >>I ran into the same problem some time ago, and made the following change to >>correct it. The bug would leak 8KB of memory each time cyg_io_lookup() was >>called for a termios device (after the first time). > > > Here is what i have committed. I removed the members from the priv > structure as well just to tidy things up. FAOD that's bound to have been the right thing to do. I suspect errbuf was just cruft from the initial implementation that was never deleted. I can't think now what it could have been intended for. Jifl -- eCosCentric http://www.eCosCentric.com/ The eCos and RedBoot experts --["No sense being pessimistic, it wouldn't work anyway"]-- Opinions==mine -- Before posting, please read the FAQ: http://ecos.sourceware.org/fom/ecos and search the list archive: http://ecos.sourceware.org/ml/ecos-discuss