From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18152 invoked by alias); 7 Jun 2006 09:14:13 -0000 Received: (qmail 17906 invoked by uid 22791); 7 Jun 2006 09:14:11 -0000 X-Spam-Check-By: sourceware.org Received: from d5152EF28.access.telenet.be (HELO lx-dmz.televic.com) (81.82.239.40) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 07 Jun 2006 09:14:09 +0000 Received: (qmail 3957 invoked from network); 7 Jun 2006 09:14:06 -0000 Received: from nt-email.televic.com (10.0.0.9) by 10.1.8.1 with SMTP; 7 Jun 2006 09:14:06 -0000 Received: from nt-server-email.TELEVIC.COM ([10.0.0.7]) by nt-email.TELEVIC.COM with Microsoft SMTPSVC(6.0.3790.1830); Wed, 7 Jun 2006 11:13:53 +0200 Received: from [10.0.56.4] ([10.0.56.4]) by nt-server-email.TELEVIC.COM with Microsoft SMTPSVC(5.0.2195.6713); Wed, 7 Jun 2006 11:13:53 +0200 Message-ID: <448698D1.6040105@televic.com> Date: Wed, 07 Jun 2006 09:14:00 -0000 From: =?ISO-8859-1?Q?J=FCrgen_Lambrecht?= User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7.12) Gecko/20050915 MIME-Version: 1.0 To: Andrew Lunn CC: eCos Discussion References: <44757FBE.8090102@tiscali.be> <20060525103532.GD6189@lunn.ch> In-Reply-To: <20060525103532.GD6189@lunn.ch> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 8bit X-IsSubscribed: yes Mailing-List: contact ecos-discuss-help@ecos.sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: ecos-discuss-owner@ecos.sourceware.org Subject: Re: [ECOS] tftp server stack problems X-SW-Source: 2006-06/txt/msg00066.txt.bz2 Hello Andrew, The patch is OK. In my application, CYGPKG_NET_TFTPD_THREAD_STACK_SIZE is set to 3948. Thanks, Juergen Jürgen Lambrecht Development Engineer Televic Transport Systems http://www.televic.com Televic NV / SA (main office) Leo Bekaertlaan 1 B-8870 Izegem Tel: +32 (0)51 303045 Fax: +32 (0)51 310670 Andrew Lunn wrote: > On Thu, May 25, 2006 at 11:58:22AM +0200, J?rgen Lambrecht wrote: > >>Hello, >> >>I use the freeBSD networking stack, but the default stack size for the >>tftp server is wrong: >> >> cdl_option CYGPKG_NET_TFTPD_THREAD_STACK_SIZE { >> display "Stack size for TFTP threads." >> flavor data >> default_value (CYGNUM_HAL_STACK_SIZE_TYPICAL+(3*(SEGSIZE+4))) >> >>When I use the configtool, or idem with ecosconfig with scripts, >>CYGNUM_HAL_STACK_SIZE_TYPICAL is always 0! > > > It looks like this has been broken since 2004-06-17. > CYGNUM_HAL_STACK_SIZE_TYPICAL is not a CDL variable, it is a #define > in the architecture HAL. > > Please could you test this patch. > > Thanks > Andrew > > > ------------------------------------------------------------------------ > > Index: net/common/current/ChangeLog > =================================================================== > RCS file: /cvs/ecos/ecos-opt/net/net/common/current/ChangeLog,v > retrieving revision 1.76 > diff -u -r1.76 ChangeLog > --- net/common/current/ChangeLog 26 Mar 2006 11:15:06 -0000 1.76 > +++ net/common/current/ChangeLog 25 May 2006 10:35:13 -0000 > @@ -1,3 +1,10 @@ > +2006-05-25 Andrew Lunn > + > + * cdl/net.cdl: Fix calculation of TFTPD stack > + size. CYGNUM_HAL_STACK_SIZE_TYPICAL is not a CDL variable, it is a > + #define, so we need to ensure that the compiler evaluates the > + expression, not the CDL library. > + > 2006-03-26 Andrew Lunn > > * tests/nc_test_framework.h: > Index: net/common/current/cdl/net.cdl > =================================================================== > RCS file: /cvs/ecos/ecos-opt/net/net/common/current/cdl/net.cdl,v > retrieving revision 1.15 > diff -u -r1.15 net.cdl > --- net/common/current/cdl/net.cdl 2 Aug 2004 10:43:39 -0000 1.15 > +++ net/common/current/cdl/net.cdl 25 May 2006 10:35:14 -0000 > @@ -170,7 +170,7 @@ > cdl_option CYGPKG_NET_TFTPD_THREAD_STACK_SIZE { > display "Stack size for TFTP threads." > flavor data > - default_value (CYGNUM_HAL_STACK_SIZE_TYPICAL+(3*(SEGSIZE+4))) > + default_value { "(CYGNUM_HAL_STACK_SIZE_TYPICAL+(3*(SEGSIZE+4)))" } > description " > This option controls the size of the stack used for the > TFTP server. The default should be sufficient for most cases > > -- Before posting, please read the FAQ: http://ecos.sourceware.org/fom/ecos and search the list archive: http://ecos.sourceware.org/ml/ecos-discuss