From: Tad <ecos_removethispart@ds3switch.com>
To: ecos-discuss@sources.redhat.com
Subject: Re: [ECOS] SNMP re-inits when session closed or trapsink removed -- FIX
Date: Sun, 17 Jun 2007 19:53:00 -0000 [thread overview]
Message-ID: <4672F28E.7090007@ds3switch.com> (raw)
In-Reply-To: <20070615120741.GC27270@lunn.ch>
I guess I'm kinda confused. I thought that perfect patches went to
ecos-patches and proposed fixes went to ecos-discuss. Was trying to
follow the rules proposed last time I posted.
- Tod
+ Tad
Andrew Lunn wrote:
>> Here's the quick fix. Most people probably don't close trapsinks too
>> often and perhaps didn't even notice snmp re-init when they did.
>>
>> snmpd.c : receive()
>> ...
>> count = select(numfds, &fdset, 0, 0, tvp);
>>
>> if (count > 0){
>> snmp_read(&fdset);
>> } else switch(count){
>> case 0:
>> snmp_timeout();
>> break;
>> case -1:
>> - if (errno == EINTR){
>> + if (errno == EINTR || errno == EBADF){
>> continue;
>> } else {
>> snmp_log_perror("select");
>> }
>>
>>
>
> Hi Tod
>
> Please send a real patch. Take a look at the other patches sent to the
> ecos-discuss list. Edit the ChangeLog file to show what you changed
> and why. Then do cvs diff -u packacges/net/snmp and send the patch it
> generates. We don't accept fixes in any other format.
>
> Thanks
> Andrew
>
>
>
--
Before posting, please read the FAQ: http://ecos.sourceware.org/fom/ecos
and search the list archive: http://ecos.sourceware.org/ml/ecos-discuss
next prev parent reply other threads:[~2007-06-15 19:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-15 18:06 Tad
2007-06-15 18:41 ` Andrew Lunn
2007-06-17 19:53 ` Tad [this message]
2007-06-17 19:58 ` Andrew Lunn
2007-06-17 21:41 ` Tad
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4672F28E.7090007@ds3switch.com \
--to=ecos_removethispart@ds3switch.com \
--cc=ecos-discuss@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).