From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15019 invoked by alias); 15 Jun 2007 19:12:40 -0000 Received: (qmail 15008 invoked by uid 22791); 15 Jun 2007 19:12:39 -0000 X-Spam-Check-By: sourceware.org Received: from sccrmhc13.comcast.net (HELO sccrmhc13.comcast.net) (204.127.200.83) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 15 Jun 2007 19:12:37 +0000 Received: from [192.168.1.200] (c-67-188-0-30.hsd1.ca.comcast.net[67.188.0.30]) by comcast.net (sccrmhc13) with ESMTP id <2007061519123501300soeeqe>; Fri, 15 Jun 2007 19:12:35 +0000 Message-ID: <4672F28E.7090007@ds3switch.com> Date: Sun, 17 Jun 2007 19:53:00 -0000 From: Tad User-Agent: Thunderbird 1.5 (Windows/20051201) MIME-Version: 1.0 To: ecos-discuss@sources.redhat.com References: <46726D19.50602@ds3switch.com> <20070615120741.GC27270@lunn.ch> In-Reply-To: <20070615120741.GC27270@lunn.ch> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Mailing-List: contact ecos-discuss-help@ecos.sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: ecos-discuss-owner@ecos.sourceware.org Subject: Re: [ECOS] SNMP re-inits when session closed or trapsink removed -- FIX X-SW-Source: 2007-06/txt/msg00175.txt.bz2 I guess I'm kinda confused. I thought that perfect patches went to ecos-patches and proposed fixes went to ecos-discuss. Was trying to follow the rules proposed last time I posted. - Tod + Tad Andrew Lunn wrote: >> Here's the quick fix. Most people probably don't close trapsinks too >> often and perhaps didn't even notice snmp re-init when they did. >> >> snmpd.c : receive() >> ... >> count = select(numfds, &fdset, 0, 0, tvp); >> >> if (count > 0){ >> snmp_read(&fdset); >> } else switch(count){ >> case 0: >> snmp_timeout(); >> break; >> case -1: >> - if (errno == EINTR){ >> + if (errno == EINTR || errno == EBADF){ >> continue; >> } else { >> snmp_log_perror("select"); >> } >> >> > > Hi Tod > > Please send a real patch. Take a look at the other patches sent to the > ecos-discuss list. Edit the ChangeLog file to show what you changed > and why. Then do cvs diff -u packacges/net/snmp and send the patch it > generates. We don't accept fixes in any other format. > > Thanks > Andrew > > > -- Before posting, please read the FAQ: http://ecos.sourceware.org/fom/ecos and search the list archive: http://ecos.sourceware.org/ml/ecos-discuss