From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1440 invoked by alias); 15 Jun 2007 19:39:59 -0000 Received: (qmail 1431 invoked by uid 22791); 15 Jun 2007 19:39:58 -0000 X-Spam-Check-By: sourceware.org Received: from alnrmhc16.comcast.net (HELO alnrmhc16.comcast.net) (206.18.177.56) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 15 Jun 2007 19:39:57 +0000 Received: from [192.168.1.200] (c-67-188-0-30.hsd1.ca.comcast.net[67.188.0.30]) by comcast.net (alnrmhc16) with ESMTP id <20070615193955b1600ggei5e>; Fri, 15 Jun 2007 19:39:55 +0000 Message-ID: <4672F8F7.4030908@earthlink.net> Date: Sun, 17 Jun 2007 21:41:00 -0000 From: Tad User-Agent: Thunderbird 1.5 (Windows/20051201) MIME-Version: 1.0 To: ecos-discuss@sources.redhat.com References: <46726D19.50602@ds3switch.com> <20070615120741.GC27270@lunn.ch> <4672F28E.7090007@ds3switch.com> <20070615192151.GB24147@lunn.ch> In-Reply-To: <20070615192151.GB24147@lunn.ch> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Mailing-List: contact ecos-discuss-help@ecos.sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: ecos-discuss-owner@ecos.sourceware.org Subject: Re: [ECOS] SNMP re-inits when session closed or trapsink removed -- FIX X-SW-Source: 2007-06/txt/msg00177.txt.bz2 Andrew Lunn wrote: > So this is not a perfect fix? What is wrong with this fix? What would > you like to discuss about this fix? All you did was provide a fix, but > gave us no clues as to why you have not made a proper patch..... I guess I thought that my original comment suggested there might be a more appropriate fix. > The simple fix appears to be to simply continue as if nothing > happened, but it's possible that snmp_select_info() never should have > added the closing socket to fdset in the first place. It was getting > very hard for me to determine whether the select was already > outstanding when the socket closed or whether someone didn't set a > proper "closing" flag that snmp_select_info() would recognize. I tried > updating the snmp_select_info() to rev 1.245 of the 4.2 net-snmp tree > which looks at closing sessions, but that didn't seem to help. -- Before posting, please read the FAQ: http://ecos.sourceware.org/fom/ecos and search the list archive: http://ecos.sourceware.org/ml/ecos-discuss