[ECOS] Re: Patch for SNMP ipNetToMediaTable to return ARP entries

[ECOS] Re: Patch for SNMP ipNetToMediaTable to return ARP entries

[Tad]

Oops:

-        long_ret = (nettomedia_list[low_ia].rt_flags | RTF_STATIC)? 
IPNETTOMEDIATYPE_STATIC:IPNETTOMEDIATYPE_DYNAMIC;

+        long_ret = (nettomedia_list[low_ia].rt_flags & RTF_STATIC)? 
IPNETTOMEDIATYPE_STATIC:IPNETTOMEDIATYPE_DYNAMIC;


-- 
Before posting, please read the FAQ: http://ecos.sourceware.org/fom/ecos
and search the list archive: http://ecos.sourceware.org/ml/ecos-discuss

Re: [ECOS] Re: Patch for SNMP ipNetToMediaTable to return ARP entries

[Tad]

Gary Thomas wrote:
> It's nice that you keep sending these changes, but is there some reason
> you can't send a proper patch, along with ChangeLog entries?  If
> we can't apply your changes directly from a patch it takes more
> time and is prone to error (and on my part at least, will simply
> be ignored...)
>   

This change in this case was a | to an & in a patch I had submitted 10 
minutes earlier.

My ecos has more patches than just what I send, so it's a long process 
to remove my specific patches before sending a pretty ecos-community 
patched file.

Creating a new diff would have taken me 5+ minutes.  Suggesting you 
change the patchfile I sent from a | to an & would take all of us 5 
seconds.  Sometimes those computers they use to enter a customer order 
at McDonald's are slower than shouting burger,burger,chips, 
pepsi-no-coke.  Also, you're dealing with an EE not a CS.  This is 
pretty good.


-- 
Before posting, please read the FAQ: http://ecos.sourceware.org/fom/ecos
and search the list archive: http://ecos.sourceware.org/ml/ecos-discuss

Re: [ECOS] Re: Patch for SNMP ipNetToMediaTable to return ARP entries

[Andrew Lunn]

> This change in this case was a | to an & in a patch I had submitted 10 
> minutes earlier.

So it should be fresh in your memory has to how you created the
patch.....

> My ecos has more patches than just what I send, so it's a long process 
> to remove my specific patches before sending a pretty ecos-community 
> patched file.

For many cases 

cvs diff -u ChangeLog src/foo.c

will be sufficient and will ignore all your changes in other files...

> Also, you're dealing with an EE not a CS.  This is 
> pretty good.

My first degree is as a Bachelor of Engineering, yet somehow i manage
to create patches. For an EE, you have good CS knowledge, which makes
this statement even stranger.

     Andrew

-- 
Before posting, please read the FAQ: http://ecos.sourceware.org/fom/ecos
and search the list archive: http://ecos.sourceware.org/ml/ecos-discuss