From: Gary Thomas <gary@mlbassoc.com>
To: "René Nielsen" <rbn@vitesse.com>
Cc: ecos-discuss@ecos.sourceware.org
Subject: Re: [ECOS] Re[ECOS] dBoot: "fis load -d" allows "go" even if it fails
Date: Wed, 28 Nov 2007 15:00:00 -0000 [thread overview]
Message-ID: <474D8071.4050008@mlbassoc.com> (raw)
In-Reply-To: <13993780.post@talk.nabble.com>
René Nielsen wrote:
> Hello,
>
> If you do a
> fis load -d my_image
>
> and my_image is not a valid zip-image, it will not be loaded. That's fine.
> But a following "go" will jump to the img->entry_point anyway.
>
> When loading an image without the -d option and CYGSEM_REDBOOT_FIS_CRC_CHECK
> is defined and the checksum-check fails, it will set entry_addr to
> NO_MEMORY. I think the same thing should happen when the unzip fails.
Send a patch :-)
BTW, I've looked at your other patch and in general I think it's
fine. It is rather involved, so we need a Copyright assignment
before I can consider it for commitment.
http://ecos.sourceware.org/assign.html
--
------------------------------------------------------------
Gary Thomas | Consulting for the
MLB Associates | Embedded world
------------------------------------------------------------
--
Before posting, please read the FAQ: http://ecos.sourceware.org/fom/ecos
and search the list archive: http://ecos.sourceware.org/ml/ecos-discuss
next prev parent reply other threads:[~2007-11-28 14:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-28 14:51 René Nielsen
2007-11-28 15:00 ` Gary Thomas [this message]
2007-11-30 11:48 ` [ECOS] " René Nielsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=474D8071.4050008@mlbassoc.com \
--to=gary@mlbassoc.com \
--cc=ecos-discuss@ecos.sourceware.org \
--cc=rbn@vitesse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).