* [ECOS] Re[ECOS] dBoot: "fis load -d" allows "go" even if it fails
@ 2007-11-28 14:51 René Nielsen
2007-11-28 15:00 ` Gary Thomas
0 siblings, 1 reply; 3+ messages in thread
From: René Nielsen @ 2007-11-28 14:51 UTC (permalink / raw)
To: ecos-discuss
Hello,
If you do a
fis load -d my_image
and my_image is not a valid zip-image, it will not be loaded. That's fine.
But a following "go" will jump to the img->entry_point anyway.
When loading an image without the -d option and CYGSEM_REDBOOT_FIS_CRC_CHECK
is defined and the checksum-check fails, it will set entry_addr to
NO_MEMORY. I think the same thing should happen when the unzip fails.
Regards
René Schipp von Branitz Nielsen
Vitesse Semiconductors
--
View this message in context: http://www.nabble.com/RedBoot%3A-%22fis-load--d%22-allows-%22go%22-even-if-it-fails-tf4888998.html#a13993780
Sent from the Sourceware - ecos-discuss mailing list archive at Nabble.com.
--
Before posting, please read the FAQ: http://ecos.sourceware.org/fom/ecos
and search the list archive: http://ecos.sourceware.org/ml/ecos-discuss
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [ECOS] Re[ECOS] dBoot: "fis load -d" allows "go" even if it fails
2007-11-28 14:51 [ECOS] Re[ECOS] dBoot: "fis load -d" allows "go" even if it fails René Nielsen
@ 2007-11-28 15:00 ` Gary Thomas
2007-11-30 11:48 ` [ECOS] " René Nielsen
0 siblings, 1 reply; 3+ messages in thread
From: Gary Thomas @ 2007-11-28 15:00 UTC (permalink / raw)
To: René Nielsen; +Cc: ecos-discuss
René Nielsen wrote:
> Hello,
>
> If you do a
> fis load -d my_image
>
> and my_image is not a valid zip-image, it will not be loaded. That's fine.
> But a following "go" will jump to the img->entry_point anyway.
>
> When loading an image without the -d option and CYGSEM_REDBOOT_FIS_CRC_CHECK
> is defined and the checksum-check fails, it will set entry_addr to
> NO_MEMORY. I think the same thing should happen when the unzip fails.
Send a patch :-)
BTW, I've looked at your other patch and in general I think it's
fine. It is rather involved, so we need a Copyright assignment
before I can consider it for commitment.
http://ecos.sourceware.org/assign.html
--
------------------------------------------------------------
Gary Thomas | Consulting for the
MLB Associates | Embedded world
------------------------------------------------------------
--
Before posting, please read the FAQ: http://ecos.sourceware.org/fom/ecos
and search the list archive: http://ecos.sourceware.org/ml/ecos-discuss
^ permalink raw reply [flat|nested] 3+ messages in thread
* [ECOS] Re: Re[ECOS] dBoot: "fis load -d" allows "go" even if it fails
2007-11-28 15:00 ` Gary Thomas
@ 2007-11-30 11:48 ` René Nielsen
0 siblings, 0 replies; 3+ messages in thread
From: René Nielsen @ 2007-11-30 11:48 UTC (permalink / raw)
To: ecos-discuss
> Send a patch :-)
> BTW, I've looked at your other patch and in general I think it's
> fine.
I've merged the patch with the zip-auto-detect patch in the ecos-devel
mailing list (see e.g.
http://www.nabble.com/forum/ViewPost.jtp?post=14042399&framed=y).
> It is rather involved, so we need a Copyright assignment
> before I can consider it for commitment.
> http://ecos.sourceware.org/assign.html
Done.
/René
--
View this message in context: http://www.nabble.com/RedBoot%3A-%22fis-load--d%22-allows-%22go%22-even-if-it-fails-tf4888998.html#a14042405
Sent from the Sourceware - ecos-discuss mailing list archive at Nabble.com.
--
Before posting, please read the FAQ: http://ecos.sourceware.org/fom/ecos
and search the list archive: http://ecos.sourceware.org/ml/ecos-discuss
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-11-30 9:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-11-28 14:51 [ECOS] Re[ECOS] dBoot: "fis load -d" allows "go" even if it fails René Nielsen
2007-11-28 15:00 ` Gary Thomas
2007-11-30 11:48 ` [ECOS] " René Nielsen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).