From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20385 invoked by alias); 19 Dec 2007 15:19:27 -0000 Received: (qmail 20371 invoked by uid 22791); 19 Dec 2007 15:19:26 -0000 X-Spam-Check-By: sourceware.org Received: from 204-133-123-27.dia.static.slbbi.com (HELO mail.chez-thomas.org) (204.133.123.27) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 19 Dec 2007 15:19:21 +0000 Received: by mail.chez-thomas.org (Postfix, from userid 999) id 42DFD19502B9; Wed, 19 Dec 2007 08:19:19 -0700 (MST) Received: from [192.168.1.101] (hermes_local [192.168.1.101]) by mail.chez-thomas.org (Postfix) with ESMTP id 1A69A19500C3; Wed, 19 Dec 2007 08:19:17 -0700 (MST) Message-ID: <47693674.20608@mlbassoc.com> Date: Wed, 19 Dec 2007 23:39:00 -0000 From: Gary Thomas User-Agent: Thunderbird 1.5.0.12 (X11/20070530) MIME-Version: 1.0 To: eCos Disuss References: <20071219112458.GB5944@lunn.ch> <20071219141733.GD5944@lunn.ch> <20071219151107.GE5944@lunn.ch> In-Reply-To: <20071219151107.GE5944@lunn.ch> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact ecos-discuss-help@ecos.sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: ecos-discuss-owner@ecos.sourceware.org Subject: Re: [ECOS] Re: Improving TFTP performance X-SW-Source: 2007-12/txt/msg00121.txt.bz2 Andrew Lunn wrote: > On Wed, Dec 19, 2007 at 03:47:32PM +0100, ?yvind Harboe wrote: >> On Dec 19, 2007 3:17 PM, Andrew Lunn wrote: >>>> + cdl_option CYGPKG_NET_TFTPD_CLIENT_GET_PACKETSIZE { >>>> + display "TFTP protocol allows negotiation of bigger packets. >>>> + Requires server which supports RFC 2348 blksize negotiation." >>>> + flavor data >>>> + default_value 512 >>>> + legal_values 512 to 65464 >>>> + description " >>>> + tftp blksize egotiation support. >512 byte block sizes improves >>>> + tftp GET performance" >>>> + } >>> The display should be kept to one line maximum. Put all the rest on >>> the description lines. You should also say that the default value of >>> 512 causes this to be disabled. It might even be better to change the >>> flavor of this to booldata, so it can be enabled/disabled and the >>> value set. It then makes your code cleaner. >> I fought w/booldata for a bit, but couldn't make sense of it. > > Something like this is O.K. > > cdl_component CYGOPY_NET_TFTPD_CLIENT_BIG_PACKET { > display "Extension to allow negotiation of big packets" > flavor bool > default_value 0 > > description "Implements RFC XXXX, an optional extension to the TFTP > protocol to allow the client and server to negotiate > to use bigger packets. This can make upload/download > faster" > > cdl_option CYGOPY_NET_TFTPD_CLIENT_BIG_PACKET { > display "Packet size to negotiate" > flavor data > default_value 32768 > legal_values 8 to 65535 > description " > Size of the packets to negotiate. In an error free > environment, bigger packets will result in faster transfers." > } > } > > > This will make your code cleaner. You no longer need the hard coded > 512 > etc. CYGOPY_??? AFAIK, this isn't one of our normal prefixes (and for namespace pollution issues, we _try_ to remain consistent). Maybe you want CYGOPT_??? -- ------------------------------------------------------------ Gary Thomas | Consulting for the MLB Associates | Embedded world ------------------------------------------------------------ -- Before posting, please read the FAQ: http://ecos.sourceware.org/fom/ecos and search the list archive: http://ecos.sourceware.org/ml/ecos-discuss