From: Jonathan Larmour <jifl@eCosCentric.com>
To: "Graves, Daniel (GE Healthcare)" <Daniel.Graves@ge.com>
Cc: ecos-discuss@ecos.sourceware.org
Subject: Re: [ECOS] Serial Driver imrpovement
Date: Sun, 01 Jul 2012 02:37:00 -0000 [thread overview]
Message-ID: <4FEFB7E1.307@eCosCentric.com> (raw)
In-Reply-To: <6F6D3EC964AAC24D9C45644424DE2D810C2F6486@CINMLVEM19.e2k.ad.ge.com>
On 22/06/12 17:10, Graves, Daniel (GE Healthcare) wrote:
> I found that the following code in Serial.c will cause a buffer overflow
> if there is garbage data on the wire before a thread has started reading
> from the serial port:
>
> ------------------------------------------------
> static rcv_req_reply_t
> serial_data_rcv_req(serial_channel *chan, int avail,
> int* space_avail, unsigned char** space)
> {
[snip]
> // Check for space
> gap = cbuf->nb;
> if (gap == cbuf->len)
> return CYG_RCV_FULL;
>
> ----------------------
>
> The line gap == cbuf->len will not always evaluate to true if garbage data
> is received. This will cause the put variable to shoot way past len.
I don't yet follow the situation you are concerned about. This generic layer
doesn't know about garbage data. Garbage data is just data, and whether before
or after a thread has started reading from the serial port, the underlying
hardware serial driver needs to call serial_data_rcv_req() when data is
received and act accordingly based on the return code.
Based on what you're saying, you are implying that cbuf->nb > cbuf->len ? If
so, then something has gone wrong... I imagine that the hardware driver is not
respecting space_avail on return from serial_data_rcv_req().
Are you using an eCos serial driver or something you wrote yourself?
Jifl
--
eCosCentric Limited http://www.eCosCentric.com/ The eCos experts
Barnwell House, Barnwell Drive, Cambridge, UK. Tel: +44 1223 245571
Registered in England and Wales: Reg No 4422071.
------["Si fractum non sit, noli id reficere"]------ Opinions==mine
--
Before posting, please read the FAQ: http://ecos.sourceware.org/fom/ecos
and search the list archive: http://ecos.sourceware.org/ml/ecos-discuss
prev parent reply other threads:[~2012-07-01 2:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-22 16:10 Graves, Daniel (GE Healthcare)
2012-07-01 2:37 ` Jonathan Larmour [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FEFB7E1.307@eCosCentric.com \
--to=jifl@ecoscentric.com \
--cc=Daniel.Graves@ge.com \
--cc=ecos-discuss@ecos.sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).