From: Sergei Organov <osv@javad.com>
To: ecos-discuss@ecos.sourceware.org
Cc: Nick Garnett <nickg@ecoscentric.com>
Subject: Re: [ECOS] Re: DSR stops running after heavy interrupts. Bug found?
Date: Mon, 10 Apr 2006 10:44:00 -0000 [thread overview]
Message-ID: <8764lhbthh.fsf@javad.com> (raw)
In-Reply-To: <m3k69x93hz.fsf@xl5.calivar.com> (Nick Garnett's message of "10 Apr 2006 10:36:08 +0100")
Nick Garnett <nickg@ecoscentric.com> writes:
> Sergei Organov <osv@javad.com> writes:
>
>> Andrew Lunn <andrew@lunn.ch> writes:
>>
>> [...]
>>
>> > However, from what you are saying it sounds like there needs to be
>> > another comparison afterwards. Something like:
>> >
>> > and r0,r0,#2 // CYG_ISR_CALL_DSR
>> > beq 17f
>>
>> No, bit checking of the ISR return value is performed inside the
>> interrupt_end() routine:
>>
>> if( isr_ret & Cyg_Interrupt::CALL_DSR && intr != NULL ) intr->post_dsr()
>
>
> Exactly. And there are other housekeeping things that go on in
> interrupt_end() which cannot be skipped. The most important of these
> is decrementing the scheduler lock.
>
> I don't really see how the original poster's problem is fixed by
> trying to skip interrupt_end(), I would only expect doing that to
> aggravate the problem. The scheduler lock is acquired early in
> interrupt processing -- before the ISR is called and we know whether
> there is a DSR to call. interrupt_end() decrements the scheduler lock
> and as a side-effect may cause any DSRs to be called.
A little OT while we are at interrupt_end(). Could you please explain
why
#ifdef CYGPKG_KERNEL_SMP_SUPPORT
Cyg_Scheduler::lock();
#endif
is there at the beginning, -- looks like extra scheduler lock without
corresponding unlock for SMP case. If not a bug, it seems a comment
would be nice to have there.
-- Sergei.
--
Before posting, please read the FAQ: http://ecos.sourceware.org/fom/ecos
and search the list archive: http://ecos.sourceware.org/ml/ecos-discuss
next prev parent reply other threads:[~2006-04-10 10:44 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-05 21:09 [ECOS] DSR stops running after heavy interrupts Joe Porthouse
2006-04-06 6:49 ` Andrew Lunn
2006-04-06 9:02 ` Stefan Sommerfeld
2006-04-06 21:09 ` Joe Porthouse
2006-04-06 21:19 ` Andrew Lunn
2006-04-08 4:18 ` [ECOS] DSR stops running after heavy interrupts. Bug found? Joe Porthouse
2006-04-09 12:33 ` Andrew Lunn
2006-04-10 4:50 ` [ECOS] " Sergei Organov
2006-04-10 9:36 ` Nick Garnett
2006-04-10 10:44 ` Sergei Organov [this message]
2006-04-10 10:59 ` Nick Garnett
2006-04-10 11:15 ` Sergei Organov
2006-04-10 13:20 ` Joe Porthouse
2006-04-10 16:41 ` [ECOS] Re: DSR stops running after heavy interrupts. Spurious Interrupt! Joe Porthouse
2006-04-10 17:20 ` Nick Garnett
2006-04-10 17:44 ` Andrew Lunn
2006-04-10 20:49 ` Joe Porthouse
2006-04-11 4:07 ` Sergei Organov
2006-04-11 8:31 ` Nick Garnett
2006-04-11 4:15 ` Sergei Organov
2006-04-11 8:43 ` Nick Garnett
2006-04-13 7:58 ` [ECOS] How to use the ARM directive DCB in Vectors.S Birahim Larou Fall
2006-04-13 13:28 ` Andrew Lunn
2006-04-13 13:32 ` Birahim Larou Fall
2006-04-21 7:40 ` [ECOS] " Daniel Néri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8764lhbthh.fsf@javad.com \
--to=osv@javad.com \
--cc=ecos-discuss@ecos.sourceware.org \
--cc=nickg@ecoscentric.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).