From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25395 invoked by alias); 19 May 2005 12:25:57 -0000 Mailing-List: contact ecos-discuss-help@ecos.sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: ecos-discuss-owner@ecos.sourceware.org Received: (qmail 23767 invoked from network); 19 May 2005 12:24:52 -0000 Received: from unknown (HELO bnls261a.sni.co.uk) (217.33.204.17) by sourceware.org with SMTP; 19 May 2005 12:24:52 -0000 Received: from bnls902a (bnls902a.sni.co.uk [10.10.10.70]) by bnls261a.sni.co.uk (Switch-3.1.2/Switch-3.1.2) with ESMTP id X4JC0Q0FV000004D4 for ; Thu, 19 May 2005 13:26:01 +0100 Received: from ples507a.stcl.siemens.co.uk ([137.223.44.136]) by bnls902a with InterScan Messaging Security Suite; Thu, 19 May 2005 13:24:47 +0100 Received: from ples506a.stcl.siemens.co.uk ([137.223.44.153]) by ples507a.stcl.siemens.co.uk with Microsoft SMTPSVC(6.0.3790.1830); Thu, 19 May 2005 13:24:35 +0100 MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: quoted-printable Content-class: urn:content-classes:message Date: Thu, 19 May 2005 14:20:00 -0000 Message-ID: From: "Retallack, Mark \(Siemens\)" To: X-OriginalArrivalTime: 19 May 2005 12:24:35.0189 (UTC) FILETIME=[B7A0DA50:01C55C6D] Subject: [ECOS] FW: Ppp echo request problem X-SW-Source: 2005-05/txt/msg00260.txt.bz2 We have had a problem with the ppp echo requests, when the ppp connection has been running for a long period of time. If the ppp peer connection is re-negotiated, then the lcp layer can start sending extra echo requests. The number of requests sent increases each time the connection is re-negotiated, eventually causing the connection to terminate automatically after one minute. The problem seems to be in lcp.c, function LcpEchoCheck. The link can be terminated during the call to LcpSendEchoRequest if the peer is not responding and this will result in the timeout being created for the link which is now closed. When the ppp is re-negotiated, the extra timeout still persists and causing the problems described above. Has anyone had this problem? Suggested fix would be to only call TIMEOUT if the ppp link is still open - see below:- static void LcpEchoCheck (f) fsm *f; { LcpSendEchoRequest (f); /* * Start the timer for the next interval, provided that the * link is still in the "OPENED" state. */ assert (lcp_echo_timer_running=3D=3D0); if (f->state =3D=3D OPENED) { TIMEOUT (LcpEchoTimeout, f, lcp_echo_interval); lcp_echo_timer_running =3D 1; } } -- Before posting, please read the FAQ: http://ecos.sourceware.org/fom/ecos and search the list archive: http://ecos.sourceware.org/ml/ecos-discuss