From: "Dave Airlie" <airlied@parthus.com>
To: "Jesper Skov" <jskov@redhat.com>
Cc: ecos-discuss@sources.redhat.com
Subject: Re: [ECOS] serial compilation with CYGINT_IO_SERIAL_BLOCK_TRANSFER
Date: Wed, 13 Sep 2000 06:37:00 -0000 [thread overview]
Message-ID: <Pine.LNX.4.21.0009131444270.8040-100000@platinum.limerick.sslinc.com> (raw)
In-Reply-To: <14783.33385.815370.483214@thinktwice.zoftcorp.dk>
Doh... should have spotted that one .. was running on no breakfast brain
wasn't switched on :-)
Thanks,
Dave.
On Wed, 13 Sep 2000, Jesper Skov wrote:
> >>>>> "Dave" == Dave Airlie <airlied@parthus.com> writes:
>
> Dave> Here are the compiler errors...
>
> Dave> /home/airlied/devel/ecos-000908/ecos/packages/io/serial/current/src/common/
> Dave> serial.c
> Dave> /home/airlied/devel/ecos-000908/ecos/packages/io/serial/current/src/common/
> Dave> serial.c:89: warning: initialization from incompatible pointer
> Dave> type
> Dave> /home/airlied/devel/ecos-000908/ecos/packages/io/serial/current/src/common/
> Dave> serial.c:89: parse error before `serial_indicate_status'
> Dave> /home/airlied/devel/ecos-000908/ecos/packages/io/serial/current/src/common/
> Dave> serial.c:1029: warning: `serial_data_xmt_done' defined but not
> Dave> used make[1]: *** [src/common/serial.o.d] Error 1
>
> That should have told you what was wrong. Didn't you look at the code? :)
>
> Try the below.
>
> Jesper
>
> Index: ChangeLog
> ===================================================================
> RCS file: /local/cvsfiles/ecc/ecc/io/serial/current/ChangeLog,v
> retrieving revision 1.206
> diff -u -5 -r1.206 ChangeLog
> --- ChangeLog 2000/09/06 07:53:47 1.206
> +++ ChangeLog 2000/09/13 13:33:14
> @@ -1,5 +1,9 @@
> +2000-09-13 Jesper Skov <jskov@redhat.com>
> +
> + * include/serial.h (SERIAL_CALLBACKS): Fix typo.
> +
> 2000-09-06 Jesper Skov <jskov@redhat.com>
>
> * tests/ser_test_protocol.inl: Renamed some option names due to SH
> serial driver reorg.
>
> Index: include/serial.h
> ===================================================================
> RCS file: /local/cvsfiles/ecc/ecc/io/serial/current/include/serial.h,v
> retrieving revision 1.13
> diff -u -5 -r1.13 serial.h
> --- include/serial.h 2000/08/01 08:59:13 1.13
> +++ include/serial.h 2000/09/13 13:33:07
> @@ -93,11 +93,11 @@
> _xmt_char, \
> _rcv_char, \
> _data_rcv_req, \
> _data_rcv_done, \
> _data_xmt_req, \
> - _data_xmt_done \
> + _data_xmt_done, \
> _indicate_status \
> };
> # else
> # define SERIAL_CALLBACKS(_l,_init,_xmt_char,_rcv_char, _data_rcv_req, _data_rcv_done, _data_xmt_req, _data_xmt_done) \
> serial_callbacks_t _l = { \
>
--
David Airlie, Software Engineer, Parthus Technologies plc.,
Mary Rosse Centre, National Tech Park, Limerick, Ireland.
t: +353-61-508116 / f: +353-61-508101 / David.Airlie@parthus.com
prev parent reply other threads:[~2000-09-13 6:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2000-09-13 3:22 Dave Airlie
2000-09-13 4:14 ` Jesper Skov
2000-09-13 4:45 ` Dave Airlie
2000-09-13 4:52 ` Jesper Skov
2000-09-13 6:17 ` Dave Airlie
2000-09-13 6:34 ` Jesper Skov
2000-09-13 6:37 ` Dave Airlie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.21.0009131444270.8040-100000@platinum.limerick.sslinc.com \
--to=airlied@parthus.com \
--cc=ecos-discuss@sources.redhat.com \
--cc=jskov@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).