From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Dave Airlie" <airlied@parthus.com>
To: "Jesper Skov" <jskov@redhat.com>
Cc: ecos-discuss@sources.redhat.com
Subject: Re: [ECOS] serial compilation with CYGINT_IO_SERIAL_BLOCK_TRANSFER
Date: Wed, 13 Sep 2000 06:37:00 -0000
Message-id: <Pine.LNX.4.21.0009131444270.8040-100000@platinum.limerick.sslinc.com>
References: <14783.33385.815370.483214@thinktwice.zoftcorp.dk>
X-SW-Source: 2000-09/msg00199.html

Doh... should have spotted that one .. was running on no breakfast brain
wasn't switched on :-)

Thanks,
Dave.

On Wed, 13 Sep 2000, Jesper Skov wrote:

> >>>>> "Dave" == Dave Airlie <airlied@parthus.com> writes:
> 
> Dave> Here are the compiler errors...
> 
> Dave> /home/airlied/devel/ecos-000908/ecos/packages/io/serial/current/src/common/
> Dave> serial.c
> Dave> /home/airlied/devel/ecos-000908/ecos/packages/io/serial/current/src/common/
> Dave> serial.c:89: warning: initialization from incompatible pointer
> Dave> type
> Dave> /home/airlied/devel/ecos-000908/ecos/packages/io/serial/current/src/common/
> Dave> serial.c:89: parse error before `serial_indicate_status'
> Dave> /home/airlied/devel/ecos-000908/ecos/packages/io/serial/current/src/common/
> Dave> serial.c:1029: warning: `serial_data_xmt_done' defined but not
> Dave> used make[1]: *** [src/common/serial.o.d] Error 1
> 
> That should have told you what was wrong. Didn't you look at the code? :)
> 
> Try the below.
> 
> Jesper
> 
> Index: ChangeLog
> ===================================================================
> RCS file: /local/cvsfiles/ecc/ecc/io/serial/current/ChangeLog,v
> retrieving revision 1.206
> diff -u -5 -r1.206 ChangeLog
> --- ChangeLog	2000/09/06 07:53:47	1.206
> +++ ChangeLog	2000/09/13 13:33:14
> @@ -1,5 +1,9 @@
> +2000-09-13  Jesper Skov  <jskov@redhat.com>
> +
> +	* include/serial.h (SERIAL_CALLBACKS): Fix typo.
> +
>  2000-09-06  Jesper Skov  <jskov@redhat.com>
>  
>  	* tests/ser_test_protocol.inl: Renamed some option names due to SH
>  	serial driver reorg.
>  
> Index: include/serial.h
> ===================================================================
> RCS file: /local/cvsfiles/ecc/ecc/io/serial/current/include/serial.h,v
> retrieving revision 1.13
> diff -u -5 -r1.13 serial.h
> --- include/serial.h	2000/08/01 08:59:13	1.13
> +++ include/serial.h	2000/09/13 13:33:07
> @@ -93,11 +93,11 @@
>      _xmt_char,                                          \
>      _rcv_char,                                          \
>      _data_rcv_req,                                      \
>      _data_rcv_done,                                     \
>      _data_xmt_req,                                      \
> -    _data_xmt_done                                      \
> +    _data_xmt_done,                                     \
>      _indicate_status                                    \
>  };
>  # else
>  #  define SERIAL_CALLBACKS(_l,_init,_xmt_char,_rcv_char, _data_rcv_req, _data_rcv_done, _data_xmt_req, _data_xmt_done)  \
>  serial_callbacks_t _l = {                               \
> 

-- 
      David Airlie, Software Engineer, Parthus Technologies plc.,
       Mary Rosse Centre, National Tech Park, Limerick, Ireland.
   t: +353-61-508116 / f: +353-61-508101 / David.Airlie@parthus.com