public inbox for ecos-discuss@sourceware.org
 help / color / mirror / Atom feed
* [ECOS]  How to send UDP broadcast to 255.255.255.255?
@ 2009-06-15 17:42 Grant Edwards
  2009-06-15 20:36 ` Sergei Gavrikov
  2009-06-16  6:44 ` [ECOS] " Andrew Lunn
  0 siblings, 2 replies; 14+ messages in thread
From: Grant Edwards @ 2009-06-15 17:42 UTC (permalink / raw)
  To: ecos-discuss

I've been asked by one of my internal customers how to send a
UDP broadcast packet to IP address 255.255.255.255.

I tried setting the SO_BROADCAST option on the socket and then
using sendto() with a destination address of 255.255.255.255,
but it sends to the subnet broadcast address (in my case
10.255.255.255) not to the global broadcast address of
255.255.255.255 that I specified in the sendto() call.

The exact same code works fine on Linux (the destination
address in the packet on the wire is 255.255.255.255), so this
is apparently platform-dependent.  The code I'm using is shown
below.  I've tried it both with and without the "bind()" call,
and it does the same thing in both cases.

Any ideas?  Is this normal BSD stack behavior?  If so, on BSD
how does one send a global broadcast?


#include <stdlib.h>
#include <unistd.h>
#include <sys/types.h>
#include <sys/socket.h>
#include <netinet/in.h>
#include <string.h>
#include <arpa/inet.h>

static void sendBroadcastUdp(void)
{
  int socket_fd;
  struct sockaddr_in encoder_addr;
  struct sockaddr_in my_addr;
  char send_buf[20];
  int broadcast=1;
  int packetSize = 5;
  int bytesSent;

  if ((socket_fd = socket(PF_INET, SOCK_DGRAM, 0)) == -1)
    {
      diag_printf("socket() failed\n");
      return;
    }

  my_addr.sin_family = AF_INET;
  my_addr.sin_port = htons(12345);
  my_addr.sin_addr.s_addr = INADDR_ANY;
  memset(my_addr.sin_zero, '\0', sizeof my_addr.sin_zero);

  #if 0
  if (bind(socket_fd, (struct sockaddr *)&my_addr, sizeof my_addr))
    {
      diag_printf("bind() failed\n");
      close(socket_fd);
      return;
    }
  #endif

  //mark the socket for broadcasting

  if (setsockopt(socket_fd, SOL_SOCKET, SO_BROADCAST, &broadcast, sizeof broadcast) == -1)
    {
      diag_printf("setsockopt (SO_BROADCAST) failed\n");
      close(socket_fd);
      return;
    }

  encoder_addr.sin_family = AF_INET;
  encoder_addr.sin_port = htons(12345);
  encoder_addr.sin_addr.s_addr = INADDR_BROADCAST;
  memset(encoder_addr.sin_zero, '\0', sizeof encoder_addr.sin_zero);

  if ((bytesSent = sendto(socket_fd, send_buf, packetSize, 0, (struct sockaddr *)&encoder_addr, sizeof encoder_addr)) == -1)
    {
      diag_printf("sendto() failed\n");
      close(socket_fd);
      return;
    }

  diag_printf("sent %d bytes to %s\n", bytesSent, inet_ntoa(encoder_addr.sin_addr));
  close(socket_fd);
}


-- 
Grant Edwards                   grante             Yow! I know th'MAMBO!!
                                  at               I have a TWO-TONE CHEMISTRY
                               visi.com            SET!!


-- 
Before posting, please read the FAQ: http://ecos.sourceware.org/fom/ecos
and search the list archive: http://ecos.sourceware.org/ml/ecos-discuss

^ permalink raw reply	[flat|nested] 14+ messages in thread
* RE: [ECOS]  Re: How to send UDP broadcast to 255.255.255.255?
@ 2009-06-16 16:14 Jay Foster
  2009-06-16 19:01 ` Grant Edwards
  0 siblings, 1 reply; 14+ messages in thread
From: Jay Foster @ 2009-06-16 16:14 UTC (permalink / raw)
  To: 'Grant Edwards', ecos-discuss

You can try the following patch that someone added to my local source.  It
adds a CDL option (CYGOPT_NET_INET_FORCE_DIRECTED_BROADCAST) to modify this
behavior (the default being the same behavior you have now).  Sorry it isn't
in "patch" format, but it is straight forward.  What is not shown here is
configuring this option to '0' in your applications .ecm or template file.

int
in_pcbladdr(inp, nam, plocal_sin)
	register struct inpcb *inp;
	struct sockaddr *nam;
	struct sockaddr_in **plocal_sin;
{
	struct in_ifaddr *ia;
	register struct sockaddr_in *sin = (struct sockaddr_in *)nam;

	if (nam->sa_len != sizeof (*sin))
		return (EINVAL);
	if (sin->sin_family != AF_INET)
		return (EAFNOSUPPORT);
	if (sin->sin_port == 0)
		return (EADDRNOTAVAIL);
	if (!TAILQ_EMPTY(&in_ifaddrhead)) {
		/*
		 * If the destination address is INADDR_ANY,
		 * use the primary local address.
		 * If the supplied address is INADDR_BROADCAST,
		 * and the primary interface supports broadcast,
		 * choose the broadcast address for that interface.
		 */
#define	satosin(sa)	((struct sockaddr_in *)(sa))
#define sintosa(sin)	((struct sockaddr *)(sin))
#define ifatoia(ifa)	((struct in_ifaddr *)(ifa))
		if (sin->sin_addr.s_addr == INADDR_ANY)
		    sin->sin_addr =
IA_SIN(TAILQ_FIRST(&in_ifaddrhead))->sin_addr;
#ifdef CYGOPT_NET_INET_FORCE_DIRECTED_BROADCAST
		else if (sin->sin_addr.s_addr == (u_long)INADDR_BROADCAST &&
		  (TAILQ_FIRST(&in_ifaddrhead)->ia_ifp->if_flags &
IFF_BROADCAST))
		    sin->sin_addr =
satosin(&TAILQ_FIRST(&in_ifaddrhead)->ia_broadaddr)->sin_addr;
#endif
	}
	if (inp->inp_laddr.s_addr == INADDR_ANY) {
		register struct route *ro;


From net.cdl:

    cdl_component CYGPKG_NET_INET {
        display       "INET support"
        active_if     CYGPKG_NET_STACK_INET
        flavor        bool
        no_define
        default_value 1
        description   "
            This option enables support for INET (IP) network processing."
        define INET
        compile \
            inet_addr.c \
            inet_ntoa.c \
            inet_ntop.c \
            inet_pton.c \
            bootp_support.c \
            dhcp_support.c \
            dhcp_prot.c \
            network_support.c \
            getproto.c \
            getserv.c 
        compile   getaddrinfo.c \
            ifaddrs.c

        cdl_option CYGOPT_NET_INET_FORCE_DIRECTED_BROADCAST {
            display       "Convert limited broadcast addresses into directed
broadcasts"
            flavor        bool
            default_value 1
            description   "
                De-facto IP stack implementations often convert
INADDR_BROADCAST
                destination addresses into a more specific directed
broadcast
                address according to the address configuration of the
primary
                network interface.  Over time, this behavior has been
criticized
                for various reasons.  The primary reason is that it becomes
                impossible to send UDP packets to 255.255.255.255 once the
                primary network (broadcast) interface is configured with
address
                information."
        }

Jay



-----Original Message-----
From: Grant Edwards [mailto:grante@visi.com]
Sent: Tuesday, June 16, 2009 7:23 AM
To: ecos-discuss@sources.redhat.com
Subject: [ECOS] Re: How to send UDP broadcast to 255.255.255.255?


On 2009-06-16, Andrew Lunn <andrew@lunn.ch> wrote:
> On Mon, Jun 15, 2009 at 05:41:54PM +0000, Grant Edwards wrote:
>> I've been asked by one of my internal customers how to send a
>> UDP broadcast packet to IP address 255.255.255.255.
>
> Hi Grant
>
> If you have a debugger handy, try putting a break point here:

I don't have one handy, but it certainly looks like the right
spot.

> src/sys/netinet/in_pcb.c
> int
> in_pcbladdr(inp, nam, plocal_sin)
>         register struct inpcb *inp;
>         struct sockaddr *nam;
>         struct sockaddr_in **plocal_sin;
> {
>         struct in_ifaddr *ia;
>         register struct sockaddr_in *sin = (struct sockaddr_in *)nam;
>
>         if (nam->sa_len != sizeof (*sin))
>                 return (EINVAL);
>         if (sin->sin_family != AF_INET)
>                 return (EAFNOSUPPORT);
>         if (sin->sin_port == 0)
>                 return (EADDRNOTAVAIL);
>         if (!TAILQ_EMPTY(&in_ifaddrhead)) {
>                 /*
>                  * If the destination address is INADDR_ANY,
>                  * use the primary local address.
>                  * If the supplied address is INADDR_BROADCAST,
>                  * and the primary interface supports broadcast,
>                  * choose the broadcast address for that interface.
>                  */
> #define satosin(sa)     ((struct sockaddr_in *)(sa))
> #define sintosa(sin)    ((struct sockaddr *)(sin))
> #define ifatoia(ifa)    ((struct in_ifaddr *)(ifa))
>                 if (sin->sin_addr.s_addr == INADDR_ANY)
>                     sin->sin_addr =
IA_SIN(TAILQ_FIRST(&in_ifaddrhead))->sin_addr;
>                 else if (sin->sin_addr.s_addr == (u_long)INADDR_BROADCAST
&&
>                   (TAILQ_FIRST(&in_ifaddrhead)->ia_ifp->if_flags &
IFF_BROADCAST))
>                     sin->sin_addr =
satosin(&TAILQ_FIRST(&in_ifaddrhead)->ia_broadaddr)->sin_addr;
>
> Unfortunately, if this is the place the address is being changed, i
> don't see an obvious way around this.


I've been doing some experiments on a FreeBSD 6.1 system, and
it won't allow applications to send a 255.255.255.255 broadcast
either.  In fact, it _requires_ you to specify the interface's
broadcast address as a destination before in order to broadcast
a packet.  FreeBSD 6.1 won't "convert" 255.255.255.255 into the
interface broadcast address the way that eCos does.

Still, the Linux implementation seems to be a lot more useful.
You can specify either 255.255.255.255 or the interface's
broadcast address as the destination, and the packet is
broadcast to that destination address.

I found complaints dating back many years regarding FreeBSD's
lack of ability to send broadcast UDP packets to
255.255.255.255.  It seems you have to use the raw socket
interface to do that.

-- 
Grant Edwards                   grante             Yow! Pardon me, but do
you
                                  at               know what it means to be
                               visi.com            TRULY ONE with your
BOOTH!


-- 
Before posting, please read the FAQ: http://ecos.sourceware.org/fom/ecos
and search the list archive: http://ecos.sourceware.org/ml/ecos-discuss

-- 
Before posting, please read the FAQ: http://ecos.sourceware.org/fom/ecos
and search the list archive: http://ecos.sourceware.org/ml/ecos-discuss

^ permalink raw reply	[flat|nested] 14+ messages in thread
* Re: [ECOS] Re: How to send UDP broadcast to 255.255.255.255?
@ 2009-08-11 13:32 Stanislav Meduna
  2009-08-12  5:02 ` Mandeep Sandhu
  0 siblings, 1 reply; 14+ messages in thread
From: Stanislav Meduna @ 2009-08-11 13:32 UTC (permalink / raw)
  To: eCos Discussion

Jay Foster wrote:

> You can try the following patch that someone added
> to my local source.  It adds a CDL option
> (CYGOPT_NET_INET_FORCE_DIRECTED_BROADCAST

I also stumbled upon the problem mentioned in the
older post and I'd like to confirm that the
patch from

  http://www.mail-archive.com/ecos-discuss@ecos.sourceware.org/msg09992.html

seems to really help. Using this and setting the default
route to my interface (code borrowed from the ppp)

static int setDefaultRoute(u_int32_t g, int cmd)
{
  static int rtm_seq;
  int routes;
  struct {
    struct rt_msghdr	hdr;
    struct sockaddr_in	dst;
    struct sockaddr_in	gway;
    struct sockaddr_in	mask;
  } rtmsg;

  if ((routes = socket(PF_ROUTE, SOCK_RAW, AF_INET)) < 0) {

    diag_printf("Couldn't %s default route: socket: %d\n",
      cmd=='s'? "add": "delete",errno);
    return 0;
  }

  memset(&rtmsg, 0, sizeof(rtmsg));
  rtmsg.hdr.rtm_type = cmd == 's'? RTM_ADD: RTM_DELETE;
  rtmsg.hdr.rtm_flags = RTF_UP | RTF_GATEWAY | RTF_STATIC;
  rtmsg.hdr.rtm_version = RTM_VERSION;
  rtmsg.hdr.rtm_seq = ++rtm_seq;
  rtmsg.hdr.rtm_addrs = RTA_DST | RTA_GATEWAY | RTA_NETMASK;
  rtmsg.dst.sin_len = sizeof(rtmsg.dst);
  rtmsg.dst.sin_family = AF_INET;
  rtmsg.gway.sin_len = sizeof(rtmsg.gway);
  rtmsg.gway.sin_family = AF_INET;
  rtmsg.gway.sin_addr.s_addr = g;
  rtmsg.mask.sin_len = sizeof(rtmsg.dst);
  rtmsg.mask.sin_family = AF_INET;

  rtmsg.hdr.rtm_msglen = sizeof(rtmsg);
  if (write(routes, &rtmsg, sizeof(rtmsg)) < 0) {
    diag_printf("Couldn't %s default route: %d\n",
      cmd=='s'? "add": "delete",errno);
    close(routes);
    return 0;
  }

  close(routes);

  return 1;
}


I am able to send the broadcasts as I intended.

I'd vote for the inclusion of the option in the main tree.

Thanks
-- 
                                Stano

-- 
Before posting, please read the FAQ: http://ecos.sourceware.org/fom/ecos
and search the list archive: http://ecos.sourceware.org/ml/ecos-discuss

^ permalink raw reply	[flat|nested] 14+ messages in thread

end of thread, other threads:[~2009-08-13  5:54 UTC | newest]

Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-06-15 17:42 [ECOS] How to send UDP broadcast to 255.255.255.255? Grant Edwards
2009-06-15 20:36 ` Sergei Gavrikov
2009-06-15 22:14   ` [ECOS] " Grant Edwards
2009-06-16  6:44 ` [ECOS] " Andrew Lunn
2009-06-16 14:23   ` [ECOS] " Grant Edwards
2009-06-16 16:14 Jay Foster
2009-06-16 19:01 ` Grant Edwards
2009-06-16 19:56   ` Gary Thomas
2009-06-16 20:26     ` Grant Edwards
2009-08-11 13:32 Stanislav Meduna
2009-08-12  5:02 ` Mandeep Sandhu
2009-08-12 13:19   ` Mandeep Sandhu
2009-08-13  5:54     ` Mandeep Sandhu
2009-08-12 13:25   ` Stanislav Meduna

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).