public inbox for ecos-discuss@sourceware.org
 help / color / mirror / Atom feed
From: Grant Edwards <grant.b.edwards@gmail.com>
To: ecos-discuss@ecos.sourceware.org
Subject: [ECOS] Re: Does FreeBSD stack support multiple IP addresses?
Date: Tue, 23 Feb 2016 15:59:00 -0000	[thread overview]
Message-ID: <nahvk4$pjt$1@ger.gmane.org> (raw)
In-Reply-To: <56CC139C.4080601@televic.com>

On 2016-02-23, Lambrecht Jürgen <J.Lambrecht@TELEVIC.com> wrote:
> On 02/22/2016 04:05 PM, Grant Edwards wrote:

>> When I tried it, the SIOCAIFADDR ioctl() let me set both address and
>> netmask in a single call.  The "case SIOCAIFADDR" code falls through
>> into SIOCSIFNETMASK code.  That didn't work for you?
>
> Indeed, I remember now that I saw that in the code, but then you have 
> the netmask according to the class A/B/C rules, and that is not what we 
> want.
>
>>> - It is only possible to assign a class A/B/C netmask. CIDR netmasks are
>>>    not possible.
>> I think that's always been the case for this version of the stack,
>> hasn't it?
> Indeed.

I just re-ran my tests and verified again that I'm able to set the IP
and netmask in a single call to ioctl(SIOCAIFADDR).  In my tests, I
tried:

 Address         Netmask
-----------      --------------
 11.0.0.104      255.0.0.0
 11.0.0.104      255.255.0.0
 11.0.0.104      255.255.255.0
 11.0.0.104      255.240.0.0
 11.0.0.104      240.0.0.0
 192.168.222.104 240.0.0.0
 192.168.222.104 255.0.0.0
 192.168.222.104 255.240.0.0
 192.168.222.104 255.255.0.0
 192.168.222.104 255.255.240.0
 192.168.222.104 255.255.255.0
 192.168.222.104 255.255.255.240

In all cases, subsequent calls to show_network_tables() showed the IP
address and netmask I requested in the ioctl() call and the correct
corresponding broadcast address.

I'm using an eCos snapshot from 2014.

>>>    I fixed current/src/sys/netinet/in.c for it, but I also adapted
>>>    the ioctl to combine setting IP address and netmask in 1 call
>>>    (so I cannot commit it back). Let me know if you want my fix.

The current SIOCAIFADDR code works fine for me.

> I changed a bit the use of the members of the "inet"-something
> struct (in the ioctl call) to also use the netmask struct member
> that is already in it. Because normally, when you call ioctl
> SIOCSIFNETMASK separately, you specify the netmask in the same
> struct member where you put the IP address for the SIOCAIFADDR call.

But the SIOCAIFADDR call as a _separate_ place where you put the
desired netmask, and AFIACT, that works.

> (I did a fast search in the linux code, but I am not used to that,
> so I did not find the "Linux way")
>
>> I'm confused: based on my experiments and examination of the source
>> code, it already works that way.
>>
> Well, it is both.  Indeed, as you say above, "code falls through
> into SIOCSIFNETMASK code",

> but then it sets "the netmask according to the class A/B/C rules",
> so the netmask is _calculated_, not strictly _set_.  I am completely
> sure about this, I read that whole code part.  (And my collegues did
> the experimentation to set a 255.248.0.0 netmask resulting in a
> 255.255.0.0 mask for 172.24.0.0 which is class B)

I don't know what to tell you other than "it works fine for
me". Unless the output from show_network_tables() is wrong...

-- 
Grant Edwards               grant.b.edwards        Yow! Give them RADAR-GUIDED
                                  at               SKEE-BALL LANES and
                              gmail.com            VELVEETA BURRITOS!!


-- 
Before posting, please read the FAQ: http://ecos.sourceware.org/fom/ecos
and search the list archive: http://ecos.sourceware.org/ml/ecos-discuss

  reply	other threads:[~2016-02-23 15:59 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-19 16:35 [ECOS] " Grant Edwards
2016-02-19 18:12 ` [ECOS] " Grant Edwards
2016-02-22  8:50   ` Lambrecht Jürgen
2016-02-22 15:05     ` Grant Edwards
2016-02-23  8:09       ` Lambrecht Jürgen
2016-02-23 15:59         ` Grant Edwards [this message]
     [not found]           ` <DUB109-W90FA10A08EE609DF0BB91393A50@phx.gbl>
2016-02-24 16:47             ` Grant Edwards
2016-03-15 11:10           ` Lambrecht Jürgen
2016-03-15 14:56             ` Grant Edwards

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='nahvk4$pjt$1@ger.gmane.org' \
    --to=grant.b.edwards@gmail.com \
    --cc=ecos-discuss@ecos.sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).