[ECOS] SH build - Odd Link Error

[ECOS] SH build - Odd Link Error

[Nick - eCos Developer]

Using: GCC built for target sh: "gcc version 2.95.1 19990816 (release)"
running on Linux. Although I can get the same error on NT.

I get the link error: undefined reference to 'dsr_disable_counter'

implicating the declaration near line 60 drv_api.c:

(Complete path "ecos/packages/hal/common/current/src/drv_api.c")

Line 60+ from drv_api.c

<snip>

//--------------------------------------------------------------------------

// Statics

static volatile cyg_int32 isr_disable_counter = 1; // ISR disable counter

volatile cyg_int32 dsr_disable_counter asm("cyg_scheduler_sched_lock"); //
DSR disable counter

static cyg_interrupt* volatile dsr_list; // List of pending DSRs

<snip>

The middle declaration seems to be declaring space for
cyg_scheduler_sched_lock and simultaneously giving it the alias
dsr_disable_counter, so If I simplify this FROM:

volatile cyg_int32 dsr_disable_counter asm("cyg_scheduler_sched_lock");

TO:

volatile cyg_int32 cyg_scheduler_sched_lock;

#define dsr_disable_counter cyg_scheduler_sched_lock // DSR disable counter

It will compile and "seems" to work. Am I correct in assuming that the
original line allocated space for cyg_scheduler_sched_lock and made
dsr_disable_counter an alias for it in this file. (Other files (some
assembler) refer only to the name cyg_scheduler_sched_lock.

What is this and why the complex syntax? Is my hack equivalent?

Re: [ECOS] SH build - Odd Link Error

[Jesper Skov]

>>>>> ""Nick" == "Nick  <- eCos Developer" <n_ecos@targus.net>> writes:

"Nick> volatile cyg_int32 dsr_disable_counter
"Nick> asm("cyg_scheduler_sched_lock"); // DSR disable counter

Try the below patch.

Jesper

Index: ChangeLog
===================================================================
RCS file: /local/cvsfiles/ecc/ecc/hal/common/current/ChangeLog,v
retrieving revision 1.259
diff -u -5 -r1.259 ChangeLog
--- ChangeLog	2001/03/05 15:37:54	1.259
+++ ChangeLog	2001/03/07 07:17:02
@@ -1,5 +1,9 @@
+2001-03-07  Jesper Skov  <jskov@redhat.com>
+
+	* src/drv_api.c: Use macro to provide symbol alias.
+
 2001-03-05  Jesper Skov  <jskov@redhat.com>
 
 	* src/hal_if.c (hal_if_diag_init): Ensure the function only
 	executes once.
 
Index: src/drv_api.c
===================================================================
RCS file: /local/cvsfiles/ecc/ecc/hal/common/current/src/drv_api.c,v
retrieving revision 1.10
diff -u -5 -r1.10 drv_api.c
--- src/drv_api.c	2001/02/01 18:20:48	1.10
+++ src/drv_api.c	2001/03/07 07:16:17
@@ -60,11 +60,12 @@
 //--------------------------------------------------------------------------
 // Statics
 
 static volatile cyg_int32 isr_disable_counter = 1;  // ISR disable counter
 
-volatile cyg_int32 dsr_disable_counter asm("cyg_scheduler_sched_lock");  // DSR disable counter
+volatile cyg_int32 dsr_disable_counter  // DSR disable counter
+                      CYGBLD_ATTRIB_ASM_ALIAS( cyg_scheduler_sched_lock );
 
 static cyg_interrupt* volatile dsr_list;        // List of pending DSRs
 
 #ifdef CYGIMP_HAL_COMMON_INTERRUPTS_CHAIN
 

re: [ECOS] SH build - Odd Link Error

[Nick - eCos Developer]

Sorry, this link error shows up when build the stubs.