From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19709 invoked by alias); 8 Feb 2010 12:36:48 -0000 Received: (qmail 19700 invoked by uid 22791); 8 Feb 2010 12:36:47 -0000 X-SWARE-Spam-Status: No, hits=-2.2 required=5.0 tests=AWL,BAYES_00,SPF_PASS X-Spam-Check-By: sourceware.org Received: from hagrid.ecoscentric.com (HELO mail.ecoscentric.com) (212.13.207.197) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 08 Feb 2010 12:36:43 +0000 Received: from localhost (hagrid.ecoscentric.com [127.0.0.1]) by mail.ecoscentric.com (Postfix) with ESMTP id A10682F78009; Mon, 8 Feb 2010 12:36:41 +0000 (GMT) Received: from mail.ecoscentric.com ([127.0.0.1]) by localhost (hagrid.ecoscentric.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id nhiKwNMe55ot; Mon, 8 Feb 2010 12:36:35 +0000 (GMT) Date: Mon, 08 Feb 2010 12:36:00 -0000 Message-Id: From: Bart Veer To: Jay Foster CC: ecos-discuss@sources.redhat.com In-reply-to: <4B6B076C.6020405@systech.com> (message from Jay Foster on Thu, 04 Feb 2010 09:44:12 -0800) References: <471205.59207.qm@web51906.mail.re2.yahoo.com> <20091019104557.GA19013@sg-ubuntu.local> <964415.68782.qm@web51911.mail.re2.yahoo.com> <20091019135211.GA17646@sg-ubuntu.local> <404723.91676.qm@web51903.mail.re2.yahoo.com> <20091024123837.GA3998@sg-laptop> <738229.12555.qm@web51906.mail.re2.yahoo.com> <20091025132007.GA4436@sg-laptop> <005101ca5622$d9bf4c30$8d3de490$@gellatly@netic.com> <46171.9697145329$1256910809@news.gmane.org> <4B6B076C.6020405@systech.com> Mailing-List: contact ecos-discuss-help@ecos.sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: ecos-discuss-owner@ecos.sourceware.org Subject: Re: [ECOS] pthread_kill return value X-SW-Source: 2010-02/txt/msg00023.txt.bz2 >>>>> "Jay" == Jay Foster writes: Jay> According to the man page for pthread_kill, the return value Jay> is supposed to be 0 on success and an error number (ESRCH, Jay> EINVAL) on error. However, the eCos implementation is Jay> returning 0 on success and -1 on error with errno set to the Jay> error number. It looks like the eCos pthread_kill() function Jay> is using the SIGNAL_RETURN() macro when it should be using Jay> the SIGNAL_RETURN_VALUE() macro. Jay> Am I reading this correctly? According to http://www.opengroup.org/onlinepubs/009695399/functions/pthread_kill.html the man page is correct. I guess the eCos implementation should be using SIGNAL_RETURN_VALUE() instead of SIGNAL_RETURN(). A patch would be welcome. The only use of pthread_kill() in the eCos sources appears to be in io/fileio, the pselect.c testcase, so that would need fixing as well. Bart -- Bart Veer eCos Configuration Architect eCosCentric Limited The eCos experts http://www.ecoscentric.com/ Barnwell House, Barnwell Drive, Cambridge, UK. Tel: +44 1223 245571 Registered in England and Wales: Reg No 4422071. Besuchen Sie uns vom 2-4 März auf der Embedded World 2010, Stand 11-208 Visit us at Embedded World 2010, Nürnberg-Germany, 2-4 Mar, Stand 11-208 -- Before posting, please read the FAQ: http://ecos.sourceware.org/fom/ecos and search the list archive: http://ecos.sourceware.org/ml/ecos-discuss