From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26331 invoked by alias); 17 Feb 2004 15:09:25 -0000 Mailing-List: contact ecos-maintainers-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Post: List-Help: , Sender: ecos-maintainers-owner@sources.redhat.com Received: (qmail 26322 invoked from network); 17 Feb 2004 15:09:24 -0000 Subject: Re: FWD: JFFS2 : Node info mutex fix suggestion. From: Gary Thomas To: David Woodhouse Cc: Andrew Lunn , eCos Maintainers In-Reply-To: <1077029910.18703.103.camel@hades.cambridge.redhat.com> References: <20040216170742.GF29388@lunn.ch> <1077027103.17692.32.camel@hermes> <1077029910.18703.103.camel@hades.cambridge.redhat.com> Content-Type: text/plain Organization: MLB Associates Message-Id: <1077030562.17692.55.camel@hermes> Mime-Version: 1.0 X-Mailer: Ximian Evolution 1.4.5 (1.4.5-7) Date: Tue, 17 Feb 2004 15:09:00 -0000 Content-Transfer-Encoding: 7bit X-Spam-Level: X-Spam-Status: No, hits=0.0 required=5.0 tests=none autolearn=no version=2.60 X-Spam-Checker-Version: SpamAssassin 2.60 (1.212-2003-09-23-exp) on hermes.chez-thomas.org X-SW-Source: 2004-02/txt/msg00017.txt.bz2 On Tue, 2004-02-17 at 07:58, David Woodhouse wrote: > On Tue, 2004-02-17 at 07:11 -0700, Gary Thomas wrote: > > On Mon, 2004-02-16 at 10:07, Andrew Lunn wrote: > > > Hi Folks > > > > > > Does anybody know how locking should work in the jffs2 package? > > > > > > To me this patch looks the wrong solution. > > > > I agree. I did already pass this to David, with no reply :-( > > Hmmm. I think the answer is to remove the one in jffs2_do_new_inode() > instead. > > That function should rely on the OS-specific code to pass it a struct > jffs2_inode_info which is initialised correctly, and that includes > having a locked semaphore in it. > > I've committed the appropriate change to my CVS tree. Thanks, I'll merge this to the eCos repository. There are also some changes in our tree (CDL stuff mostly) that need to be pushed your way. I'll take care of that as well. -- Gary Thomas MLB Associates