From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10898 invoked by alias); 27 Mar 2003 18:32:35 -0000 Mailing-List: contact ecos-maintainers-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Post: List-Help: , Sender: ecos-maintainers-owner@sources.redhat.com Received: (qmail 10891 invoked from network); 27 Mar 2003 18:32:34 -0000 Content-Type: text/plain; charset="iso-8859-1" From: John Dallaway Organization: eCosCentric Limited To: ecos-maintainers@sources.redhat.com Subject: Re: [APPROVE] __cxa_pure_virtual() Date: Thu, 27 Mar 2003 18:32:00 -0000 User-Agent: KMail/1.4.3 References: <20030327175605.5459FEC6F1@delenn.bartv.net> <3E833DDE.3090709@eCosCentric.com> In-Reply-To: <3E833DDE.3090709@eCosCentric.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Message-Id: <200303271835.09792.jld@ecoscentric.com> X-SW-Source: 2003-03/txt/msg00075.txt.bz2 I have no objection to this patch for the eCos 2.0 branch. John Dallaway -----Original Message----- From: Jonathan Larmour Date: Thursday 27 Mar 2003 18:07 Subject: Re: [APPROVE] __cxa_pure_virtual() > Bart Veer wrote: > > I have just committed a patch to CYGPKG_INFRA to provide an > > implementation of __cxa_pure_virtual() that is appropriate for eCos, > > overriding the one in libsupc++. > > > > http://sources.redhat.com/ml/ecos-patches/2003-03/msg00209.html > > No objection in principle, although I think you could add a diag_printf > after the CYG_FAIL saying the same thing so there is some potential > diagnostic if people don't have asserts enabled. > > Perhaps even > #ifdef CYGDBG_USE_ASSERTS > CYG_FAIL > #else > diag_printf > #endif > > Whatever the specific implementation, the patch is worth including in > 2.0. > > Jifl