From: Andrew Lunn <andrew.lunn@ascom.ch>
To: eCos Maintainers <ecos-maintainers@sources.redhat.com>
Subject: Aprove: M_ZERO cyg_net_malloc flag
Date: Tue, 29 Apr 2003 07:51:00 -0000 [thread overview]
Message-ID: <20030429075123.GY21714@biferten.ma.tech.ascom.ch> (raw)
Aprovel request for the 2.0 branch:
Name: M_ZERO flag for cyg_net_malloc()
Purpose: The bsd_tcpip MALLOC macro can pass the flag
M_ZERO. cyg_net_malloc ignores this so leaving random junk in the
memory returned. This can then cause calls like getpeername and
getsockname to return sockaddr with junk in there tails. When such a
sockaddr is then passed back into the stack with a bind call, the bind
fails because of the junk.
Risk: Small.
Affected packages: bsd_tcpip and anything depending on it.
Andrew
Index: packages/net/bsd_tcpip//current/ChangeLog
===================================================================
RCS file: /cvs/ecos/ecos-opt/net/net/bsd_tcpip/current/ChangeLog,v
retrieving revision 1.17.2.1
diff -u -r1.17.2.1 ChangeLog
--- packages/net/bsd_tcpip//current/ChangeLog 14 Mar 2003 13:44:37 -0000 1.17.2.1
+++ packages/net/bsd_tcpip//current/ChangeLog 29 Apr 2003 07:46:10 -0000
@@ -1,3 +1,8 @@
+2003-04-29 Andrew Lunn <andrew.lunn@ascom.ch>
+
+ * src/ecos/support.c (cyg_net_malloc): Honour the M_ZERO
+ flag. Otherwise we get random junk in places we don't want it.
+
2003-03-14 Andrew Lunn <andrew.lunn@ascom.ch>
* src/sys/net/if.c (if_attach): Removed printf which causes the
Index: packages/net/bsd_tcpip//current/src/ecos/support.c
===================================================================
RCS file: /cvs/ecos/ecos-opt/net/net/bsd_tcpip/current/src/ecos/support.c,v
retrieving revision 1.4
diff -u -r1.4 support.c
--- packages/net/bsd_tcpip//current/src/ecos/support.c 3 Dec 2002 17:22:46 -0000 1.4
+++ packages/net/bsd_tcpip//current/src/ecos/support.c 29 Apr 2003 07:46:11 -0000
@@ -201,6 +201,9 @@
} else {
res = cyg_mempool_var_alloc(net_mem, size);
}
+ if ((flags & M_ZERO) && res) {
+ memset(res,0,size);
+ }
FINISH_STATS(stats_malloc);
log(LOG_MDEBUG, "%p\n", res);
return (res);
next reply other threads:[~2003-04-29 7:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-04-29 7:51 Andrew Lunn [this message]
2003-04-29 13:32 ` Gary Thomas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030429075123.GY21714@biferten.ma.tech.ascom.ch \
--to=andrew.lunn@ascom.ch \
--cc=ecos-maintainers@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).