From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ecos-maintainers-return-547-listarch-ecos-maintainers=sources.redhat.com@sources.redhat.com>
Received: (qmail 12233 invoked by alias); 14 Oct 2003 07:22:40 -0000
Mailing-List: contact ecos-maintainers-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:ecos-maintainers-subscribe@sources.redhat.com>
List-Post: <mailto:ecos-maintainers@sources.redhat.com>
List-Help: <mailto:ecos-maintainers-help@sources.redhat.com>, <http://sources.redhat.com/lists.html#faqs>
Sender: ecos-maintainers-owner@sources.redhat.com
Received: (qmail 12116 invoked from network); 14 Oct 2003 07:22:38 -0000
Date: Tue, 14 Oct 2003 07:22:00 -0000
To: eCos Maintainers <ecos-maintainers@sources.redhat.com>
Cc: ecos-patches@sources.redhat.com
Subject: Re: ARM HAL exception handling
Message-ID: <20031014072240.GA1885@lunn.ch>
References: <200310131818.30676.thomas.koeller@baslerweb.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200310131818.30676.thomas.koeller@baslerweb.com>
User-Agent: Mutt/1.5.4i
From: Andrew Lunn <andrew@lunn.ch>
X-SW-Source: 2003-10/txt/msg00014.txt.bz2

Hi folks

I don't know enough about thumb to deal with this patch. Please can
someone else take a look.

        Thanks
                Andrew

On Mon, Oct 13, 2003 at 06:18:30PM +0200, Thomas Koeller wrote:
> Exception handling in the ARM architectural HAL does not quite work
> when running in THUMB mode. Patch attached.
> 
> diff -ru packages-orig/hal/arm/arch/current/ChangeLog packages/hal/arm/arch/current/ChangeLog
> --- packages-orig/hal/arm/arch/current/ChangeLog	2003-06-30 14:16:16.000000000 +0200
> +++ packages/hal/arm/arch/current/ChangeLog	2003-10-13 18:12:41.000000000 +0200
> @@ -1,3 +1,7 @@
> +2003-10-13  Thomas Koeller  <thomas.koeller@baslerweb.com>
> +
> +	* src/vectors.S: Fixed broken thumb mode exception handling.
> +
>  2003-06-30  Mark Salter  <msalter@redhat.com>
>  
>  	* src/vectors.S: Fix CYGOPT_HAL_ARM_PRESERVE_SVC_SPSR handling.
> diff -ru packages-orig/hal/arm/arch/current/src/vectors.S packages/hal/arm/arch/current/src/vectors.S
> --- packages-orig/hal/arm/arch/current/src/vectors.S	2003-06-30 14:16:16.000000000 +0200
> +++ packages/hal/arm/arch/current/src/vectors.S	2003-10-13 17:52:49.000000000 +0200
> @@ -622,13 +622,16 @@
>          mov     r0,sp
>          ldr     r1,.__dump_procs
>          ldr     r2,[sp,#armreg_vector]
> +        ldr     r1,[r1,r2,lsl #2]
> +        THUMB_MODE(r9,10)
>          mov     lr,pc
> -        ldr     pc,[r1,r2,lsl #2]
> +        mov     pc,r1
> +#else
> +        THUMB_MODE(r9,10)
>  #endif
>  
>          // call exception handler
>          mov     r0,sp
> -        THUMB_MODE(r9,10)
>          bl      exception_handler
>  
>  #ifdef  CYGHWR_HAL_ARM_DUMP_EXCEPTIONS
> 
> --------------------------------------------------
> 
> Thomas Koeller, Software Development
> 
> Basler Vision Technologies
> An der Strusbek 60-62
> 22926 Ahrensburg
> Germany
> 
> Tel +49 (4102) 463-162
> Fax +49 (4102) 463-239
> 
> mailto:thomas.koeller@baslerweb.com
> http://www.baslerweb.com
> 
> ==============================
>