From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10001 invoked by alias); 12 Feb 2009 14:32:31 -0000 Received: (qmail 9992 invoked by uid 22791); 12 Feb 2009 14:32:30 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from ascomax.hasler.ascom.ch (HELO ascomax.hasler.ascom.ch) (139.79.135.1) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 12 Feb 2009 14:32:22 +0000 Received: from eiger.ma.tech.ascom.ch (eiger.ma.tech.ascom.ch [139.79.100.1]) by ascomax.hasler.ascom.ch (8.14.1/8.14.1) with ESMTP id n1CEWFDg023321; Thu, 12 Feb 2009 15:32:15 +0100 (MET) Received: from [139.79.100.143] (helo=donkey.ma.tech.ascom.ch) by eiger.ma.tech.ascom.ch with esmtp (Exim 3.16 #1) id 1LXcbn-0003vR-00; Thu, 12 Feb 2009 15:32:07 +0100 Received: from lunn by donkey.ma.tech.ascom.ch with local (Exim 3.36 #1 (Debian)) id 1LXcbp-0002Wv-00; Thu, 12 Feb 2009 15:32:09 +0100 Date: Thu, 12 Feb 2009 14:32:00 -0000 From: Andrew Lunn To: Nick Garnett Cc: Andrew Lunn , John Dallaway , ecos-maintainers@ecos.sourceware.org Subject: Re: AT91EB55 and DataFlash Message-ID: <20090212143209.GO24614@donkey.ma.tech.ascom.ch> References: <4994113A.4040308@dallaway.org.uk> <20090212125602.GI24614@donkey.ma.tech.ascom.ch> <20090212134950.GL24614@donkey.ma.tech.ascom.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.18 (2008-05-17) X-IsSubscribed: yes Mailing-List: contact ecos-maintainers-help@ecos.sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: ecos-maintainers-owner@ecos.sourceware.org X-SW-Source: 2009-02/txt/msg00020.txt.bz2 On Thu, Feb 12, 2009 at 02:27:13PM +0000, Nick Garnett wrote: > Andrew Lunn writes: > > > On Thu, Feb 12, 2009 at 01:56:02PM +0100, Andrew Lunn wrote: > > > On Thu, Feb 12, 2009 at 12:08:26PM +0000, John Dallaway wrote: > > > > eCos maintainers > > > > > > > > Building RedBoot for the AT91EB55 target (eb55) is currently failing due to: > > > > > > > > a) CYGPKG_ERROR missing in the RedBoot .ecm files. It is required by > > > > CYGPKG_DEVS_FLASH_ATMEL_DATAFLASH. > > > > > > I think this is because of the inclusion of IO_SPI in all targets > > > which have SPI. The dataflash CDL contains: > > > > > > cdl_package CYGPKG_DEVS_FLASH_ATMEL_DATAFLASH { > > > display "Atmel DataFlash parts support" > > > description "Support for Atmel DataFlash" > > > active_if CYGPKG_IO_SPI > > > requires CYGPKG_ERROR > > > > > > I think just adding > > > > > > active_if CYGPKG_IO_FLASH > > > > Ah, not so easy afterall. From the Changelog: > > > > 2005-06-29 Jani Monoses > > > > * include/dataflash.h: Allow the package to be compiled without > > io/flash. Return correct value from cyg_dataflash_get_page_count() > > > > It looks like the requires statement is wrong, CYGPKG_ERROR is not > > needed by dataflash. This fixes this problem, but it then explodes > > later. > > > > I think somebody from eCosCentric needs to look at this and compare > > with there working code in their private branch. > > All of the redboot ECM files for our boards with dataflash contain > CYGPKG_ERROR. CYGPKG_DEVS_FLASH_ATMEL_DATAFLASH does not, but the AT91 > SPI driver needs it. Yep, that was were it exploded. However, it should of been at ecosconfig time it complained. The AT91 SPI driver is missing a requires statement for CYGPKG_ERROR. I guess the error package should be added to all targets which use the AT91 SPI driver. Andrew