From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25514 invoked by alias); 3 Apr 2009 14:50:02 -0000 Received: (qmail 25333 invoked by uid 22791); 3 Apr 2009 14:50:01 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from ascomax.hasler.ascom.ch (HELO ascomax.hasler.ascom.ch) (139.79.135.1) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 03 Apr 2009 14:49:56 +0000 Received: from eiger.ma.tech.ascom.ch (eiger.ma.tech.ascom.ch [139.79.100.1]) by ascomax.hasler.ascom.ch (8.14.1/8.14.1) with ESMTP id n33EnpLR019804; Fri, 3 Apr 2009 16:49:51 +0200 (MEST) Received: from [139.79.100.143] (helo=donkey.ma.tech.ascom.ch) by eiger.ma.tech.ascom.ch with esmtp (Exim 3.16 #1) id 1LpkiL-0002CP-00; Fri, 03 Apr 2009 16:49:49 +0200 Received: from lunn by donkey.ma.tech.ascom.ch with local (Exim 4.69) (envelope-from ) id 1LpkiN-0000yM-60; Fri, 03 Apr 2009 16:49:51 +0200 Date: Fri, 03 Apr 2009 14:50:00 -0000 From: Andrew Lunn To: =?utf-8?B?0J3QuNC60L7Qu9Cw0Lkg0JzQsNGA0YPRgdC+0LI=?= Cc: ecos-maintainers@ecos.sourceware.org Subject: Re: Bug: KSZ8001.c Message-ID: <20090403144951.GB14208@ma.tech.ascom.ch> References: <49D61C26.4080204@rambler.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <49D61C26.4080204@rambler.ru> User-Agent: Mutt/1.5.18 (2008-05-17) X-IsSubscribed: yes Mailing-List: contact ecos-maintainers-help@ecos.sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: ecos-maintainers-owner@ecos.sourceware.org X-SW-Source: 2009-04/txt/msg00002.txt.bz2 On Fri, Apr 03, 2009 at 06:24:38PM +0400, Николай Марусов wrote: > Hello! > > I think there is a bug in "Ethernet transceiver (PHY) support for Micrel > KSZ8001" module. > > File KSZ8001.c > Line 160: _eth_phy_dev("Micrel KSZ8001", 0x00221613, ksz8001_stat) > > This causes an error at Embedded Artists 2469 platform > "Unsupported PHY device - id: ffffffff" > > Documentation from Micrel for KSZ8001L/S says that device ID must be > 0x0022161A. > > Cure is > Line 160: _eth_phy_dev("Micrel KSZ8001", 0x0022161A, ksz8001_stat) > > So, it works! > > Thank you for great job! Is this a bug? Or is it simply that Micrel have brought out a new version of the KSZ8001, the KSZ8001L/S which has a different ID? Maybe correct fix is to add a new line: _eth_phy_dev("Micrel KSZ8001L/2", 0x0022161A, ksz8001_stat); Reading the data sheets for all the different KSZ8001 would tell you this. Andrew