From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2966 invoked by alias); 27 Mar 2003 18:07:32 -0000 Mailing-List: contact ecos-maintainers-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Post: List-Help: , Sender: ecos-maintainers-owner@sources.redhat.com Received: (qmail 2959 invoked from network); 27 Mar 2003 18:07:32 -0000 Message-ID: <3E833DDE.3090709@eCosCentric.com> Date: Thu, 27 Mar 2003 18:07:00 -0000 From: Jonathan Larmour User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-GB; rv:1.3) Gecko/20030314 X-Accept-Language: en-gb, en, en-us MIME-Version: 1.0 To: Bart Veer Cc: ecos-maintainers@sources.redhat.com Subject: Re: [APPROVE] __cxa_pure_virtual() References: <20030327175605.5459FEC6F1@delenn.bartv.net> In-Reply-To: <20030327175605.5459FEC6F1@delenn.bartv.net> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2003-03/txt/msg00074.txt.bz2 Bart Veer wrote: > I have just committed a patch to CYGPKG_INFRA to provide an > implementation of __cxa_pure_virtual() that is appropriate for eCos, > overriding the one in libsupc++. > > http://sources.redhat.com/ml/ecos-patches/2003-03/msg00209.html No objection in principle, although I think you could add a diag_printf after the CYG_FAIL saying the same thing so there is some potential diagnostic if people don't have asserts enabled. Perhaps even #ifdef CYGDBG_USE_ASSERTS CYG_FAIL #else diag_printf #endif Whatever the specific implementation, the patch is worth including in 2.0. Jifl -- eCosCentric http://www.eCosCentric.com/ The eCos and RedBoot experts --[ "You can complain because roses have thorns, or you ]-- --[ can rejoice because thorns have roses." -Lincoln ]-- Opinions==mine