From: Jonathan Larmour <jifl@eCosCentric.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: eCos Maintainers <ecos-maintainers@sources.redhat.com>,
ecos-patches@sources.redhat.com
Subject: Re: ARM HAL exception handling
Date: Tue, 14 Oct 2003 23:04:00 -0000 [thread overview]
Message-ID: <3F8C80E0.1010808@eCosCentric.com> (raw)
In-Reply-To: <20031014072240.GA1885@lunn.ch>
Andrew Lunn wrote:
> Hi folks
>
> I don't know enough about thumb to deal with this patch. Please can
> someone else take a look.
Mark's the expert on this stuff AFAIK, but firstly it mostly only affects
#ifdef CYGHWR_HAL_ARM_DUMP_EXCEPTIONS stuff, so can't be too problematic.
Clearly the current stuff doesn't grok thumb at all. The change looks
reasonable.
Jifl
> Thanks
> Andrew
>
> On Mon, Oct 13, 2003 at 06:18:30PM +0200, Thomas Koeller wrote:
>
>>Exception handling in the ARM architectural HAL does not quite work
>>when running in THUMB mode. Patch attached.
>>
>>diff -ru packages-orig/hal/arm/arch/current/ChangeLog packages/hal/arm/arch/current/ChangeLog
>>--- packages-orig/hal/arm/arch/current/ChangeLog 2003-06-30 14:16:16.000000000 +0200
>>+++ packages/hal/arm/arch/current/ChangeLog 2003-10-13 18:12:41.000000000 +0200
>>@@ -1,3 +1,7 @@
>>+2003-10-13 Thomas Koeller <thomas.koeller@baslerweb.com>
>>+
>>+ * src/vectors.S: Fixed broken thumb mode exception handling.
>>+
>> 2003-06-30 Mark Salter <msalter@redhat.com>
>>
>> * src/vectors.S: Fix CYGOPT_HAL_ARM_PRESERVE_SVC_SPSR handling.
>>diff -ru packages-orig/hal/arm/arch/current/src/vectors.S packages/hal/arm/arch/current/src/vectors.S
>>--- packages-orig/hal/arm/arch/current/src/vectors.S 2003-06-30 14:16:16.000000000 +0200
>>+++ packages/hal/arm/arch/current/src/vectors.S 2003-10-13 17:52:49.000000000 +0200
>>@@ -622,13 +622,16 @@
>> mov r0,sp
>> ldr r1,.__dump_procs
>> ldr r2,[sp,#armreg_vector]
>>+ ldr r1,[r1,r2,lsl #2]
>>+ THUMB_MODE(r9,10)
>> mov lr,pc
>>- ldr pc,[r1,r2,lsl #2]
>>+ mov pc,r1
>>+#else
>>+ THUMB_MODE(r9,10)
>> #endif
>>
>> // call exception handler
>> mov r0,sp
>>- THUMB_MODE(r9,10)
>> bl exception_handler
>>
>> #ifdef CYGHWR_HAL_ARM_DUMP_EXCEPTIONS
>>
>>--------------------------------------------------
>>
>>Thomas Koeller, Software Development
>>
>>Basler Vision Technologies
>>An der Strusbek 60-62
>>22926 Ahrensburg
>>Germany
>>
>>Tel +49 (4102) 463-162
>>Fax +49 (4102) 463-239
>>
>>mailto:thomas.koeller@baslerweb.com
>>http://www.baslerweb.com
>>
>>==============================
>>
--
eCosCentric http://www.eCosCentric.com/ The eCos and RedBoot experts
--["No sense being pessimistic, it wouldn't work anyway"]-- Opinions==mine
next prev parent reply other threads:[~2003-10-14 23:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200310131818.30676.thomas.koeller@baslerweb.com>
2003-10-14 7:22 ` Andrew Lunn
2003-10-14 23:04 ` Jonathan Larmour [this message]
2003-10-15 13:39 ` Mark Salter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3F8C80E0.1010808@eCosCentric.com \
--to=jifl@ecoscentric.com \
--cc=andrew@lunn.ch \
--cc=ecos-maintainers@sources.redhat.com \
--cc=ecos-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).