public inbox for ecos-maintainers@sourceware.org
 help / color / mirror / Atom feed
* Bug: KSZ8001.c
@ 2009-04-03 14:24 Николай Марусов
  2009-04-03 14:50 ` Andrew Lunn
  0 siblings, 1 reply; 2+ messages in thread
From: Николай Марусов @ 2009-04-03 14:24 UTC (permalink / raw)
  To: ecos-maintainers

Hello!

I think there is a bug in "Ethernet transceiver (PHY) support for Micrel 
KSZ8001" module.

File KSZ8001.c
Line 160: _eth_phy_dev("Micrel KSZ8001", 0x00221613, ksz8001_stat)

This causes an error at Embedded Artists 2469 platform
"Unsupported PHY device - id: ffffffff"

Documentation from Micrel for KSZ8001L/S says that device ID must be 
0x0022161A.

Cure is
Line 160: _eth_phy_dev("Micrel KSZ8001", 0x0022161A, ksz8001_stat)

So, it works!

Thank you for great job!

Nikolay.


^ permalink raw reply	[flat|nested] 2+ messages in thread
* Re: Bug: KSZ8001.c
  2009-04-03 14:24 Bug: KSZ8001.c Николай Марусов
@ 2009-04-03 14:50 ` Andrew Lunn
  0 siblings, 0 replies; 2+ messages in thread
From: Andrew Lunn @ 2009-04-03 14:50 UTC (permalink / raw)
  To: Николай
	Марусов
  Cc: ecos-maintainers

On Fri, Apr 03, 2009 at 06:24:38PM +0400, Николай Марусов wrote:
> Hello!
>
> I think there is a bug in "Ethernet transceiver (PHY) support for Micrel  
> KSZ8001" module.
>
> File KSZ8001.c
> Line 160: _eth_phy_dev("Micrel KSZ8001", 0x00221613, ksz8001_stat)
>
> This causes an error at Embedded Artists 2469 platform
> "Unsupported PHY device - id: ffffffff"
>
> Documentation from Micrel for KSZ8001L/S says that device ID must be  
> 0x0022161A.
>
> Cure is
> Line 160: _eth_phy_dev("Micrel KSZ8001", 0x0022161A, ksz8001_stat)
>
> So, it works!
>
> Thank you for great job!

Is this a bug? Or is it simply that Micrel have brought out a new
version of the KSZ8001, the KSZ8001L/S which has a different ID?
Maybe correct fix is to add a new line:

_eth_phy_dev("Micrel KSZ8001L/2", 0x0022161A, ksz8001_stat);

Reading the data sheets for all the different KSZ8001 would tell you
this.

        Andrew

^ permalink raw reply	[flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-04-03 14:50 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-04-03 14:24 Bug: KSZ8001.c Николай Марусов
2009-04-03 14:50 ` Andrew Lunn

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).