From: John Dallaway <john@dallaway.org.uk>
To: Oliver Munz <munz@speag.ch>
Cc: eCos Maintainers <ecos-maintainers@ecos.sourceware.org>
Subject: Re: at91sam7s patch for PIT EFC PMC all in one...
Date: Fri, 03 Jul 2009 12:36:00 -0000 [thread overview]
Message-ID: <4A4DFB39.3070301@dallaway.org.uk> (raw)
Hi Oliver
Andrew Lunn has forwarded your revised patch to me. It was rejected by
the mailing list for some reason.
I note that Kasim Malla is mentioned as a contributor. Is Kasim Malla
another employee of Schmid & Partner Engineering AG? Please confirm.
John Dallaway
---- Original Message ----
Date: Tue, 16 Jun 2009 15:56:33 +0200
From: "oliver munz @ s p e a g" <munz@speag.ch>
To: Andrew Lunn <andrew@lunn.ch>
CC: ecos-patches@sourceware.org
Subject: Re: at91sam7s patch for PIT EFC PMC all in one...
Hi Andrew
The patch is working - nearly :-)... The only problem is in the function:
static __inline__ cyg_bool
flash_controller_is_ready(cyg_uint32 page)
{
cyg_uint32 fsr;
#ifdef AT91_MC_FMR1
if (page >= PAGE_AT_WHICH_WE_USE_THE_EFC1){
HAL_READ_UINT32(AT91_MC+AT91_MC_FSR1, fsr);
} else
#endif
HAL_READ_UINT32(AT91_MC+AT91_MC_FSR, fsr);
return (fsr & AT91_MC_FSR_FRDY ? true : false);
}
In Your patch this function used both times AT91_MC+AT91_MC_FSR...
I did a new .diff, adding an other little change to
packages/hal/arm/at91/at91sam7sek/current/cdl/hal_arm_at91sam7sek.cdl
Regards
Oliver
[ snip ]
next reply other threads:[~2009-07-03 12:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-03 12:36 John Dallaway [this message]
2009-07-03 13:12 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A4DFB39.3070301@dallaway.org.uk \
--to=john@dallaway.org.uk \
--cc=ecos-maintainers@ecos.sourceware.org \
--cc=munz@speag.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).