public inbox for ecos-maintainers@sourceware.org
 help / color / mirror / Atom feed
* Re: at91sam7s patch for PIT EFC PMC all in one...
@ 2009-07-03 12:36 John Dallaway
  2009-07-03 13:12 ` Andrew Lunn
  0 siblings, 1 reply; 2+ messages in thread
From: John Dallaway @ 2009-07-03 12:36 UTC (permalink / raw)
  To: Oliver Munz; +Cc: eCos Maintainers

Hi Oliver

Andrew Lunn has forwarded your revised patch to me. It was rejected by
the mailing list for some reason.

I note that Kasim Malla is mentioned as a contributor. Is Kasim Malla
another employee of Schmid & Partner Engineering AG? Please confirm.

John Dallaway


---- Original Message ----
Date: Tue, 16 Jun 2009 15:56:33 +0200
From: "oliver munz @ s p e a g" <munz@speag.ch>
To: Andrew Lunn <andrew@lunn.ch>
CC: ecos-patches@sourceware.org
Subject: Re: at91sam7s patch for PIT EFC PMC all in one...

Hi Andrew

The patch is working - nearly :-)... The only problem is in the function:

static __inline__ cyg_bool
flash_controller_is_ready(cyg_uint32 page)
{
 cyg_uint32 fsr;
#ifdef AT91_MC_FMR1
 if (page >= PAGE_AT_WHICH_WE_USE_THE_EFC1){
   HAL_READ_UINT32(AT91_MC+AT91_MC_FSR1, fsr);
 } else
#endif
   HAL_READ_UINT32(AT91_MC+AT91_MC_FSR, fsr);

 return (fsr & AT91_MC_FSR_FRDY ? true : false);
}

In Your patch this function used both times AT91_MC+AT91_MC_FSR...

I did a new .diff, adding an other little change to
packages/hal/arm/at91/at91sam7sek/current/cdl/hal_arm_at91sam7sek.cdl

Regards
Oliver

[ snip ]

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: at91sam7s patch for PIT EFC PMC all in one...
  2009-07-03 12:36 at91sam7s patch for PIT EFC PMC all in one John Dallaway
@ 2009-07-03 13:12 ` Andrew Lunn
  0 siblings, 0 replies; 2+ messages in thread
From: Andrew Lunn @ 2009-07-03 13:12 UTC (permalink / raw)
  To: John Dallaway; +Cc: Oliver Munz, eCos Maintainers

On Fri, Jul 03, 2009 at 01:36:09PM +0100, John Dallaway wrote:
> Hi Oliver
> 
> Andrew Lunn has forwarded your revised patch to me. It was rejected by
> the mailing list for some reason.
> 
> I note that Kasim Malla is mentioned as a contributor. Is Kasim Malla
> another employee of Schmid & Partner Engineering AG? Please confirm.

Hi John

I already asked this question. The answer i got is that he performed
some testing. There is no code from him.

     Andrew

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2009-07-03 13:12 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-07-03 12:36 at91sam7s patch for PIT EFC PMC all in one John Dallaway
2009-07-03 13:12 ` Andrew Lunn

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).