From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20964 invoked by alias); 3 Jul 2009 12:36:27 -0000 Received: (qmail 20955 invoked by uid 22791); 3 Jul 2009 12:36:27 -0000 X-SWARE-Spam-Status: No, hits=-1.0 required=5.0 tests=AWL,BAYES_50 X-Spam-Check-By: sourceware.org Received: from mtaout01-winn.ispmail.ntl.com (HELO mtaout01-winn.ispmail.ntl.com) (81.103.221.47) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 03 Jul 2009 12:36:19 +0000 Received: from aamtaout03-winn.ispmail.ntl.com ([81.103.221.35]) by mtaout01-winn.ispmail.ntl.com (InterMail vM.7.08.04.00 201-2186-134-20080326) with ESMTP id <20090703123615.QEI6742.mtaout01-winn.ispmail.ntl.com@aamtaout03-winn.ispmail.ntl.com>; Fri, 3 Jul 2009 13:36:15 +0100 Received: from cog.dallaway.org.uk ([86.9.207.237]) by aamtaout03-winn.ispmail.ntl.com (InterMail vG.2.02.00.01 201-2161-120-102-20060912) with ESMTP id <20090703123615.JNSY2093.aamtaout03-winn.ispmail.ntl.com@cog.dallaway.org.uk>; Fri, 3 Jul 2009 13:36:15 +0100 Received: from cog.dallaway.org.uk (cog.dallaway.org.uk [127.0.0.1]) by cog.dallaway.org.uk (8.13.8/8.13.8) with ESMTP id n63Ca9AR018902; Fri, 3 Jul 2009 13:36:09 +0100 Message-ID: <4A4DFB39.3070301@dallaway.org.uk> Date: Fri, 03 Jul 2009 12:36:00 -0000 From: John Dallaway User-Agent: Thunderbird 2.0.0.22 (X11/20090625) MIME-Version: 1.0 To: Oliver Munz CC: eCos Maintainers Subject: Re: at91sam7s patch for PIT EFC PMC all in one... Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact ecos-maintainers-help@ecos.sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: ecos-maintainers-owner@ecos.sourceware.org X-SW-Source: 2009-07/txt/msg00000.txt.bz2 Hi Oliver Andrew Lunn has forwarded your revised patch to me. It was rejected by the mailing list for some reason. I note that Kasim Malla is mentioned as a contributor. Is Kasim Malla another employee of Schmid & Partner Engineering AG? Please confirm. John Dallaway ---- Original Message ---- Date: Tue, 16 Jun 2009 15:56:33 +0200 From: "oliver munz @ s p e a g" To: Andrew Lunn CC: ecos-patches@sourceware.org Subject: Re: at91sam7s patch for PIT EFC PMC all in one... Hi Andrew The patch is working - nearly :-)... The only problem is in the function: static __inline__ cyg_bool flash_controller_is_ready(cyg_uint32 page) { cyg_uint32 fsr; #ifdef AT91_MC_FMR1 if (page >= PAGE_AT_WHICH_WE_USE_THE_EFC1){ HAL_READ_UINT32(AT91_MC+AT91_MC_FSR1, fsr); } else #endif HAL_READ_UINT32(AT91_MC+AT91_MC_FSR, fsr); return (fsr & AT91_MC_FSR_FRDY ? true : false); } In Your patch this function used both times AT91_MC+AT91_MC_FSR... I did a new .diff, adding an other little change to packages/hal/arm/at91/at91sam7sek/current/cdl/hal_arm_at91sam7sek.cdl Regards Oliver [ snip ]