From: "Bob Brusa" <bob.brusa@gmail.com>
To: "Sergei Gavrikov" <sergei.gavrikov@gmail.com>,
"John Dallaway" <john@dallaway.org.uk>
Cc: "eCos Maintainers" <ecos-maintainers@ecos.sourceware.org>
Subject: Re: How to add patches to cvs-log
Date: Fri, 12 Feb 2010 15:59:00 -0000 [thread overview]
Message-ID: <op.u70uo91z8qukij@w27> (raw)
In-Reply-To: <20100212105936.GA20021@sg-desktop>
Am 12.02.2010, 11:59 Uhr, schrieb Sergei Gavrikov
<sergei.gavrikov@gmail.com>:
> On Fri, Feb 12, 2010 at 10:32:28AM +0000, John Dallaway wrote:
>> Hi Robert
>>
>> Bob Brusa wrote:
>>
>> > on 14-Jan-2010 I sent a patch (devs_current_100114.epk) to
>> ecos-patches
>> > at sources dot redhat dot com. I assumed it would then go (after
>> review
>> > by an expert!) into the "current" cvs ecos repository. This does not
>> > seem to be the case as I learned yesterday when updating my ecos from
>> > the cvs. Did I follow a wrong procedure or does it just take some more
>> > time?
>>
>> Firstly, thank you for taking the time to contribute a patch for eCos.
>>
>> Unfortunately, patch review can take some time. The eCos maintainers
>> which are best placed to review your changes may be busy. I would
>> suggest that you re-post your changes to the ecos-patches list in the
>> form of a plain text attachment (generated using "diff -U5 -r") rather
>> than as an EPK file. This will make it much easier for individual
>> maintainers to review your changes at a glance.
>>
>> John Dallaway
>> eCos maintainer
>
> Hi Robert and John,
>
> A few years ago I knew about one link by the topic:
> http://ecos.sourceware.org/patches.html
>
> Unfortunately I cannot call where I 'bookmarked' it in my mind from.
> Just now I tried to find the reference looking the eCos front pages,
> and I couldn't find a reference on the link.
==> indeed, this link got lost - there is no path to this page and hence
no newbie will ever find it.
> But, Robert, That's it.
>
> HTH
>
> Sergei
Hi Sergei and John
I would expect that in my case, the diff-command could look as follows:
C:\cygwin\ecoscvs\ecos\packages>cvs -q diff -u5 -p devs\eth\arm\at91 >>
my.patch
However, this lists everything in this directory as "modified" - simply
because my windows based editor has changed linefeeds by the cr-lf
sequences. So I leave it for now and hope that the expert will cope with
the epk-file I handed in. After all, the relevant changes do affect the
file if_at91.c only.
Regards Robert
next prev parent reply other threads:[~2010-02-12 15:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <op.u70cspe28qukij@w27>
2010-02-12 10:32 ` John Dallaway
2010-02-12 10:59 ` Sergei Gavrikov
2010-02-12 15:59 ` Bob Brusa [this message]
2010-02-12 17:25 ` John Dallaway
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=op.u70uo91z8qukij@w27 \
--to=bob.brusa@gmail.com \
--cc=ecos-maintainers@ecos.sourceware.org \
--cc=john@dallaway.org.uk \
--cc=sergei.gavrikov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).