* Re:Re: [PATCH]:add support for at91sam7x processor to work in different supported USART MODE
@ 2009-03-30 7:57 vibisreenivasan
2009-03-30 8:13 ` Andrew Lunn
0 siblings, 1 reply; 6+ messages in thread
From: vibisreenivasan @ 2009-03-30 7:57 UTC (permalink / raw)
To: Andrew Lunn; +Cc: ecos-patches
>> AT91sam7x hardware supports different usart configurations like
>> RS485,IrDA.
>> Patch helps that to be set during compile time.
> Hi I don't really see how this helps. How do you change the mode? I
> don't see any current code which allows you to change this new mode
> field. Also, how do you handle baud rate generation? The different
> modes seem to calculate the baud rates using different formula. At
> the moment, i don't think this patch is useful.
> Andrew
hi,
thanks for looking into this code.
We can set the MODE ONLY AT COMPILE TIME.
And i really missed the baud rate generation part.
Can I add that & resubmit this again , will it be helpful?
regards
vibi
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Re: [PATCH]:add support for at91sam7x processor to work in different supported USART MODE
2009-03-30 7:57 Re:Re: [PATCH]:add support for at91sam7x processor to work in different supported USART MODE vibisreenivasan
@ 2009-03-30 8:13 ` Andrew Lunn
2009-03-30 8:27 ` vibisreenivasan
0 siblings, 1 reply; 6+ messages in thread
From: Andrew Lunn @ 2009-03-30 8:13 UTC (permalink / raw)
To: vibisreenivasan; +Cc: Andrew Lunn, ecos-patches
On Mon, Mar 30, 2009 at 01:36:27PM +0530, vibisreenivasan wrote:
> >> AT91sam7x hardware supports different usart configurations like
> >> RS485,IrDA.
> >> Patch helps that to be set during compile time.
>
> > Hi I don't really see how this helps. How do you change the mode? I
> > don't see any current code which allows you to change this new mode
> > field. Also, how do you handle baud rate generation? The different
> > modes seem to calculate the baud rates using different formula. At
> > the moment, i don't think this patch is useful.
> > Andrew
>
> hi,
> thanks for looking into this code.
> We can set the MODE ONLY AT COMPILE TIME.
How?
> And i really missed the baud rate generation part.
A lot depends on which mode you are using. Some modes do use the same
baud as normal USART. Some not.
> Can I add that & resubmit this again , will it be helpful?
It is too early to say. Keep working on it and if it does become
useful then yes. However, at the moment it is not useful.
Andrew
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Re: [PATCH]:add support for at91sam7x processor to work in different supported USART MODE
2009-03-30 8:13 ` Andrew Lunn
@ 2009-03-30 8:27 ` vibisreenivasan
2009-03-30 8:45 ` Andrew Lunn
0 siblings, 1 reply; 6+ messages in thread
From: vibisreenivasan @ 2009-03-30 8:27 UTC (permalink / raw)
To: Andrew Lunn; +Cc: ecos-patches
On Mon, 2009-03-30 at 10:12 +0200, Andrew Lunn wrote:
> On Mon, Mar 30, 2009 at 01:36:27PM +0530, vibisreenivasan wrote:
> > >> AT91sam7x hardware supports different usart configurations like
> > >> RS485,IrDA.
> > >> Patch helps that to be set during compile time.
> >
> > > Hi I don't really see how this helps. How do you change the mode? I
> > > don't see any current code which allows you to change this new mode
> > > field. Also, how do you handle baud rate generation? The different
> > > modes seem to calculate the baud rates using different formula. At
> > > the moment, i don't think this patch is useful.
> > > Andrew
> >
> > hi,
> > thanks for looking into this code.
> > We can set the MODE ONLY AT COMPILE TIME.
>
> How?
I am using the 485 mode by changing in the source code directly.
But planning to put it as a cdl option.
>
> > And i really missed the baud rate generation part.
>
> A lot depends on which mode you are using. Some modes do use the same
> baud as normal USART. Some not.
>
> > Can I add that & resubmit this again , will it be helpful?
>
> It is too early to say. Keep working on it and if it does become
> useful then yes. However, at the moment it is not useful.
>
> Andrew
>
THANKS FOR THE FEED BACK
Thanks & regards
vibi
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Re: [PATCH]:add support for at91sam7x processor to work in different supported USART MODE
2009-03-30 8:27 ` vibisreenivasan
@ 2009-03-30 8:45 ` Andrew Lunn
2009-03-30 12:26 ` vibisreenivasan
0 siblings, 1 reply; 6+ messages in thread
From: Andrew Lunn @ 2009-03-30 8:45 UTC (permalink / raw)
To: vibisreenivasan; +Cc: Andrew Lunn, ecos-patches
> > How?
> I am using the 485 mode by changing in the source code directly.
> But planning to put it as a cdl option.
CDL is the right way to do it. But do you then need the mode member in
the structure?
In 485 mode it looks like the normal baud function will work O.K.
Andrew
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Re: [PATCH]:add support for at91sam7x processor to work in different supported USART MODE
2009-03-30 8:45 ` Andrew Lunn
@ 2009-03-30 12:26 ` vibisreenivasan
2009-04-05 11:39 ` vibisreenivasan
0 siblings, 1 reply; 6+ messages in thread
From: vibisreenivasan @ 2009-03-30 12:26 UTC (permalink / raw)
To: Andrew Lunn; +Cc: ecos-patches
On Mon, 2009-03-30 at 10:45 +0200, Andrew Lunn wrote:
> > > How?
> > I am using the 485 mode by changing in the source code directly.
> > But planning to put it as a cdl option.
>
> CDL is the right way to do it. But do you then need the mode member in
> the structure?
>
I am not so well in CDL , i am working on that.
> In 485 mode it looks like the normal baud function will work O.K.
>
i has checked 485mode . it is working.
> Andrew
>
>
thanks & regards
vibi
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Re: [PATCH]:add support for at91sam7x processor to work in different supported USART MODE
2009-03-30 12:26 ` vibisreenivasan
@ 2009-04-05 11:39 ` vibisreenivasan
0 siblings, 0 replies; 6+ messages in thread
From: vibisreenivasan @ 2009-04-05 11:39 UTC (permalink / raw)
To: Andrew Lunn; +Cc: ecos-patches
hi Andrew,
Will it be okey if i trim my patch for now to just enable RS485
mode & submit separate patches for the other modes latter.
Our project uses only RS485.:)
regards
vibi
On Mon, 2009-03-30 at 18:06 +0530, vibisreenivasan wrote:
> On Mon, 2009-03-30 at 10:45 +0200, Andrew Lunn wrote:
> > > > How?
> > > I am using the 485 mode by changing in the source code directly.
> > > But planning to put it as a cdl option.
> >
> > CDL is the right way to do it. But do you then need the mode member in
> > the structure?
> >
> I am not so well in CDL , i am working on that.
> > In 485 mode it looks like the normal baud function will work O.K.
> >
> i has checked 485mode . it is working.
> > Andrew
> >
> >
> thanks & regards
> vibi
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2009-04-05 11:39 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-03-30 7:57 Re:Re: [PATCH]:add support for at91sam7x processor to work in different supported USART MODE vibisreenivasan
2009-03-30 8:13 ` Andrew Lunn
2009-03-30 8:27 ` vibisreenivasan
2009-03-30 8:45 ` Andrew Lunn
2009-03-30 12:26 ` vibisreenivasan
2009-04-05 11:39 ` vibisreenivasan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).