From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14163 invoked by alias); 25 Mar 2010 21:49:43 -0000 Received: (qmail 14153 invoked by uid 22791); 25 Mar 2010 21:49:43 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from idcmail-mo1so.shaw.ca (HELO idcmail-mo1so.shaw.ca) (24.71.223.10) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 25 Mar 2010 21:49:38 +0000 Received: from pd4ml3so-ssvc.prod.shaw.ca ([10.0.141.150]) by pd3mo1so-svcs.prod.shaw.ca with ESMTP; 25 Mar 2010 15:49:36 -0600 X-Cloudmark-SP-Filtered: true X-Cloudmark-SP-Result: v=1.0 c=1 a=rBjdMJma2q4A:10 a=VphdPIyG4kEA:10 a=MAWBuv+Rva4qgljfr6z1+w==:17 a=QRf9ejuyWbzC4ejParMA:9 a=hK_eEjAmtfMsmdRzV59fM5V0A7oA:4 a=C-al3cStqB23nETUB5UA:9 a=GDd-FAQs_NQnDJJLVb6dQEzJcg4A:4 a=QEXdDO2ut3YA:10 a=5mzYSem6DesIRQqM:21 a=S4xutXlsLuf0zSA2:21 a=B3H3McAPAAAA:8 a=wARg3mvf3MqoK2pgHwUA:9 a=gPwMzL4Snu4xNkOzhsv4ko21aisA:4 Received: from unknown (HELO [192.168.1.126]) ([24.84.208.203]) by pd4ml3so-dmz.prod.shaw.ca with ESMTP; 25 Mar 2010 15:49:36 -0600 Subject: Re: Patch fixes bad "requires" constraint in io_flash.cdl From: Daniel Helgason To: ecos-patches@ecos.sourceware.org Cc: Sergei Gavrikov In-Reply-To: References: <1269538310.3043.10.camel@localhost.localdomain> Content-Type: multipart/mixed; boundary="=-Apkl5xVTqo8HcU7F3EL9" Date: Thu, 25 Mar 2010 21:49:00 -0000 Message-Id: <1269553776.3043.67.camel@localhost.localdomain> Mime-Version: 1.0 Mailing-List: contact ecos-patches-help@ecos.sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: ecos-patches-owner@ecos.sourceware.org X-SW-Source: 2010-03/txt/msg00006.txt.bz2 --=-Apkl5xVTqo8HcU7F3EL9 Content-Type: text/plain Content-Transfer-Encoding: 7bit Content-length: 891 On Thu, 2010-03-25 at 22:21 +0200, Sergei Gavrikov wrote: > Daniel Helgason wrote: > > > Attached is a patch to > > > > ecos/packages/io/flash/current/cdl/io_flash.cdl > > > > to fix bad "requires" constraint on CYGNUM_IO_FLASH_BLOCK_OFFSET_n in > > io_flash.cdl file. > > > > In the current version, it is not possible to position a block device at > > offset 0 in the flash using "Static configuration via offset" option. > > Hi Daniel, > > Thank you for this catch. Could you provide a ChangeLog entry also? If you > used HG you can regenerate diff as `hg diff -b' to trim the ws difference. > ... Resubmitting original io_flash.cdl patch (unchanged) and also attached new patch to ecos/packages/io/flash/current/ChangeLog to add info wrt io_flash.cdl patch as requested by Sergei Gavrikov. -- +--------------------------------------------- | Daniel Helgason --=-Apkl5xVTqo8HcU7F3EL9 Content-Disposition: attachment; filename=io_flash.cdl.diff Content-Type: text/x-patch; name=io_flash.cdl.diff; charset=utf-8 Content-Transfer-Encoding: 7bit Content-length: 821 --- a/packages/io/flash/current/cdl/io_flash.cdl +++ b/packages/io/flash/current/cdl/io_flash.cdl @@ -219,7 +219,7 @@ default_value 1 compile legacy_api.c description " - Provide an implementation of the lagacy user API. This is mapped + Provide an implementation of the legacy user API. This is mapped onto the new API via a small layer of code" } @@ -283,7 +283,7 @@ display "Length" flavor data default_value 0 - requires 0 != CYGNUM_IO_FLASH_BLOCK_OFFSET_$::dev + requires 0 != CYGNUM_IO_FLASH_BLOCK_LENGTH_$::dev description " This gives the length of the region of flash given over to this block device." --=-Apkl5xVTqo8HcU7F3EL9 Content-Disposition: attachment; filename=ChangeLog.diff Content-Type: text/x-patch; name=ChangeLog.diff; charset=utf-8 Content-Transfer-Encoding: 7bit Content-length: 541 --- /a/ecos/packages/io/flash/current/ChangeLog +++ /b/ecos/packages/io/flash/current/ChangeLog @@ -1,3 +1,10 @@ +2010-03-25 Daniel Helgason + + * cdl/io_flash.cdl: Fix "requires" constraint on + CYGNUM_IO_FLASH_BLOCK_OFFSET_n to allow positioning of block device + at offset 0 in flash when using static configuration via offset. + Fix display string for CYGSEM_IO_FLASH_LEGACY_API option. + 2010-01-17 John Dallaway * src/flashiodevlegacy.c: Specify flash block device lengths correctly --=-Apkl5xVTqo8HcU7F3EL9--