From: Hans Rosenfeld <rosenfeld@grumpf.hope-2000.org>
To: ecos-patches@ecos.sourceware.org
Subject: Re: LPC2xxx CAN bugfixes
Date: Thu, 16 Aug 2007 17:04:00 -0000 [thread overview]
Message-ID: <20070816170314.GA12580@grumpf.hope-2000.org> (raw)
In-Reply-To: <20070816163126.GA17087@grumpf.hope-2000.org>
On Thu, Aug 16, 2007 at 06:31:26PM +0200, Hans Rosenfeld wrote:
> There are two bugs in the CAN driver for the LPC2xxx.
>
> One is in include/can_lpc2xxx_baudrates.h: numbers shouldn't be prefixed
> with 0 if they aren't intended to be interpreted as octal. I fixed this
> only where it actually breaks, but the rest should be changed, too.
>
> The other is in src/can_lpc2xxx.c, the definition of "info" is missing
> when only one CAN channel is configured.
I've noticed another strange thing, is there a specific reason that
tests/can_baudrates.c, tests/can_busload.c and tests/can_rx_tx.c all
#include pkgconf/devs_can_loop.h?
--
%SYSTEM-F-ANARCHISM, The operating system has been overthrown
next prev parent reply other threads:[~2007-08-16 17:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-16 16:32 Hans Rosenfeld
2007-08-16 17:04 ` Hans Rosenfeld [this message]
2007-08-17 5:55 cetoni GmbH - Uwe Kindler
2007-08-17 7:44 cetoni GmbH - Uwe Kindler
2007-08-17 8:11 ` Andrew Lunn
2007-08-17 8:33 ` cetoni GmbH - Uwe Kindler
2007-08-17 8:49 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070816170314.GA12580@grumpf.hope-2000.org \
--to=rosenfeld@grumpf.hope-2000.org \
--cc=ecos-patches@ecos.sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).