From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20892 invoked by alias); 16 Aug 2007 17:04:15 -0000 Received: (qmail 20811 invoked by uid 22791); 16 Aug 2007 17:04:14 -0000 X-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,DK_POLICY_SIGNSOME X-Spam-Check-By: sourceware.org Received: from quina.moeckel.org (HELO quina.moeckel.org) (217.160.223.98) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 16 Aug 2007 17:04:05 +0000 Received: from bluebird.headcrashers.bnfh (bluebird.headcrashers.org [IPv6:2001:8d8:81:a11:204:acff:fe97:190]) (authenticated bits=0) by quina.moeckel.org (8.13.8/8.13.8/Debian-3) with ESMTP id l7GH3up5007162 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT) for ; Thu, 16 Aug 2007 19:03:56 +0200 Received: from executor.headcrashers.bnfh (IDENT:root@executor.headcrashers.bnfh [IPv6:2001:8d8:81:a11:209:6bff:fee0:8244]) by bluebird.headcrashers.bnfh (8.13.8/8.13.8) with ESMTP id l7GH3tFk004750 for ; Thu, 16 Aug 2007 19:03:55 +0200 Received: from executor.headcrashers.bnfh (IDENT:woodstoc@localhost [127.0.0.1]) by executor.headcrashers.bnfh (8.13.8/8.13.8) with ESMTP id l7GH3FIF016103 for ; Thu, 16 Aug 2007 19:03:15 +0200 (CEST) Received: (from woodstoc@localhost) by executor.headcrashers.bnfh (8.13.8/8.13.8/Submit) id l7GH3Fk1008771 for ecos-patches@ecos.sourceware.org; Thu, 16 Aug 2007 19:03:15 +0200 (CEST) Date: Thu, 16 Aug 2007 17:04:00 -0000 From: Hans Rosenfeld To: ecos-patches@ecos.sourceware.org Subject: Re: LPC2xxx CAN bugfixes Message-ID: <20070816170314.GA12580@grumpf.hope-2000.org> References: <20070816163126.GA17087@grumpf.hope-2000.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070816163126.GA17087@grumpf.hope-2000.org> User-Agent: Mutt/1.4.2.2i X-Spam-Checker-Version: SpamAssassin 3.1.7-deb (2006-10-05) on quina.moeckel.org X-IsSubscribed: yes Mailing-List: contact ecos-patches-help@ecos.sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: ecos-patches-owner@ecos.sourceware.org X-SW-Source: 2007-08/txt/msg00020.txt.bz2 On Thu, Aug 16, 2007 at 06:31:26PM +0200, Hans Rosenfeld wrote: > There are two bugs in the CAN driver for the LPC2xxx. > > One is in include/can_lpc2xxx_baudrates.h: numbers shouldn't be prefixed > with 0 if they aren't intended to be interpreted as octal. I fixed this > only where it actually breaks, but the rest should be changed, too. > > The other is in src/can_lpc2xxx.c, the definition of "info" is missing > when only one CAN channel is configured. I've noticed another strange thing, is there a specific reason that tests/can_baudrates.c, tests/can_busload.c and tests/can_rx_tx.c all #include pkgconf/devs_can_loop.h? -- %SYSTEM-F-ANARCHISM, The operating system has been overthrown