From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31567 invoked by alias); 21 Aug 2007 07:36:48 -0000 Received: (qmail 31535 invoked by uid 22791); 21 Aug 2007 07:36:46 -0000 X-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,DK_POLICY_SIGNSOME X-Spam-Check-By: sourceware.org Received: from quina.moeckel.org (HELO quina.moeckel.org) (217.160.223.98) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 21 Aug 2007 07:36:43 +0000 Received: from bluebird.headcrashers.bnfh (bluebird.headcrashers.org [IPv6:2001:8d8:81:a11:204:acff:fe97:190]) (authenticated bits=0) by quina.moeckel.org (8.13.8/8.13.8/Debian-3) with ESMTP id l7L7aXkL018748 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Tue, 21 Aug 2007 09:36:34 +0200 Received: from executor.headcrashers.bnfh (IDENT:root@executor.headcrashers.bnfh [IPv6:2001:8d8:81:a11:209:6bff:fee0:8244]) by bluebird.headcrashers.bnfh (8.13.8/8.13.8) with ESMTP id l7L7aWxj016282; Tue, 21 Aug 2007 09:36:32 +0200 Received: from executor.headcrashers.bnfh (IDENT:woodstoc@localhost [127.0.0.1]) by executor.headcrashers.bnfh (8.13.8/8.13.8) with ESMTP id l7L7ZkB9001241; Tue, 21 Aug 2007 09:35:46 +0200 (CEST) Received: (from woodstoc@localhost) by executor.headcrashers.bnfh (8.13.8/8.13.8/Submit) id l7L7ZkJv001114; Tue, 21 Aug 2007 09:35:46 +0200 (CEST) Date: Tue, 21 Aug 2007 07:36:00 -0000 From: Hans Rosenfeld To: cetoni GmbH - Uwe Kindler Cc: ecos-patches@sourceware.org Subject: Re: LPC2xxx patch for support of vectored interrupt controller Message-ID: <20070821073546.GA635@grumpf.hope-2000.org> References: <46CA81F3.60109@cetoni.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <46CA81F3.60109@cetoni.de> User-Agent: Mutt/1.4.2.2i X-Spam-Checker-Version: SpamAssassin 3.1.7-deb (2006-10-05) on quina.moeckel.org X-IsSubscribed: yes Mailing-List: contact ecos-patches-help@ecos.sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: ecos-patches-owner@ecos.sourceware.org X-SW-Source: 2007-08/txt/msg00038.txt.bz2 On Tue, Aug 21, 2007 at 08:10:59AM +0200, cetoni GmbH - Uwe Kindler wrote: > I dont't agree with this change. If I configure a system and do a > mistake setting up interrupt priorities then my only chance and a very > good way to catch this error is this assertion. If you silently drop > this failure just to make a test case happy then you may pass the test > but you will run into trouble with your real application. This function is not used for setting up priorities, but for interrupt polarity and mode, which is only valid for the external interrupts. I doubt anyone would even think about changing the polarity of an internal interrupt or would try to use an internal interrupt for some external devices by accident, except for code like the test case that doesn't know and doesn't care. But, maybe the code should emit a warning if it is attempted. > Btw. the assertion I put into the code is wrong: > > CYG_ASSERT(vector <= CYGNUM_HAL_INTERRUPT_EINT3 && > vector >= CYGNUM_HAL_INTERRUPT_EINT0 , "Invalid vector"); > I'm pretty sure this is correct. -- %SYSTEM-F-ANARCHISM, The operating system has been overthrown