From: Andrew Lunn <andrew@lunn.ch>
To: Hans Rosenfeld <rosenfeld@grumpf.hope-2000.org>
Cc: ecos-patches@sourceware.org, andrew@lunn.ch, uwe.kindler@cetoni.de
Subject: Re: LPC2xxx patch for support of vectored interrupt controller
Date: Wed, 22 Aug 2007 09:45:00 -0000 [thread overview]
Message-ID: <20070822094455.GI31057@lunn.ch> (raw)
In-Reply-To: <20070822092307.GC2126@grumpf.hope-2000.org>
> > Should there also be another check like:
> >
> > CYG_ASSERT(vector <= CYGNUM_HAL_ISR_MAX &&
> > vector >= CYGNUM_HAL_ISR_MIN , "Invalid vector");
> >
> > If you pass it an invalid vector, such as 33, you end up shifting 1 by
> > 33 which i guess results in 0. The code will then set/reset the level
> > on every single interrupt!
>
> This assertion cannot fail if the previous assertion did not fail
O.K. Fine. I just asked the question, is this needed. And the answer is now clear. No.
Thanks
Andrew
next prev parent reply other threads:[~2007-08-22 9:45 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-21 6:12 cetoni GmbH - Uwe Kindler
2007-08-21 7:36 ` Hans Rosenfeld
2007-08-22 8:42 ` Andrew Lunn
2007-08-22 9:23 ` Hans Rosenfeld
2007-08-22 9:45 ` Andrew Lunn [this message]
2007-08-22 9:49 ` cetoni GmbH - Uwe Kindler
-- strict thread matches above, loose matches on Subject: below --
2007-07-10 6:11 uwe.kindler
2007-07-30 18:10 ` Andrew Lunn
2007-08-17 14:02 ` Hans Rosenfeld
2007-08-17 17:14 ` Hans Rosenfeld
2007-08-20 5:52 ` cetoni GmbH - Uwe Kindler
2007-08-20 15:14 ` Hans Rosenfeld
2007-08-22 8:25 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070822094455.GI31057@lunn.ch \
--to=andrew@lunn.ch \
--cc=ecos-patches@sourceware.org \
--cc=rosenfeld@grumpf.hope-2000.org \
--cc=uwe.kindler@cetoni.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).