From: Andrew Lunn <andrew@lunn.ch>
To: Sergei Gavrikov <w3sg@SoftHome.net>
Cc: eCos patches list <ecos-patches@ecos.sourceware.org>
Subject: Re: hal/arm/acrh/hal_misc.c (fix warning)
Date: Tue, 11 Sep 2007 18:05:00 -0000 [thread overview]
Message-ID: <20070911180529.GO3557@lunn.ch> (raw)
In-Reply-To: <20070901221314.GA20932@ubuntu>
[-- Attachment #1: Type: text/plain, Size: 352 bytes --]
On Sun, Sep 02, 2007 at 01:13:14AM +0300, Sergei Gavrikov wrote:
> Add a function prototype to avoid compiler warning in dump_frame(), it
> occurs when a CDL option CYGHWR_HAL_ARM_DUMP_EXCEPTIONS is selected.
Hi Sergei
Thanks for the patch. I decided instead to just include
<cyg/infra/diag.h> rather than had a prototype.
Andrew
[-- Attachment #2: hal_arm_arch.diff --]
[-- Type: text/x-diff, Size: 1449 bytes --]
Index: hal/arm/arch/current/ChangeLog
===================================================================
RCS file: /cvs/ecos/ecos/packages/hal/arm/arch/current/ChangeLog,v
retrieving revision 1.109
diff -u -r1.109 ChangeLog
--- hal/arm/arch/current/ChangeLog 4 Feb 2007 00:16:42 -0000 1.109
+++ hal/arm/arch/current/ChangeLog 11 Sep 2007 18:03:53 -0000
@@ -1,3 +1,9 @@
+2007-09-11 Andrew Lunn <andrew.lunn@ascom.ch>
+
+ * src/hal_misc.c: Include <cyg/infra/diag.h> to prevent compiler
+ warning when CYGHWR_HAL_ARM_DUMP_EXCEPTIONS is enabled.
+ Reported by Sergei Gavrikov <w3sg@SoftHome.net.
+
2007-02-03 Sergei Gavrikov <sg@sgs.gomel.by>
* src/vectors.S: Added a possibility to fix ARM vector 0x14
Index: hal/arm/arch/current/src/hal_misc.c
===================================================================
RCS file: /cvs/ecos/ecos/packages/hal/arm/arch/current/src/hal_misc.c,v
retrieving revision 1.20
diff -u -r1.20 hal_misc.c
--- hal/arm/arch/current/src/hal_misc.c 24 May 2004 12:32:10 -0000 1.20
+++ hal/arm/arch/current/src/hal_misc.c 11 Sep 2007 18:03:53 -0000
@@ -67,7 +67,7 @@
#include <cyg/hal/hal_arch.h> // HAL header
#include <cyg/hal/hal_intr.h> // HAL header
-externC void diag_printf(const char *fmt, ...);
+#include <cyg/infra/diag.h>
/*------------------------------------------------------------------------*/
/* First level C exception handler. */
prev parent reply other threads:[~2007-09-11 18:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-01 22:14 Sergei Gavrikov
2007-09-11 18:05 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070911180529.GO3557@lunn.ch \
--to=andrew@lunn.ch \
--cc=ecos-patches@ecos.sourceware.org \
--cc=w3sg@SoftHome.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).