public inbox for ecos-patches@sourceware.org
 help / color / mirror / Atom feed
* hal/arm/acrh/hal_misc.c (fix warning)
@ 2007-09-01 22:14 Sergei Gavrikov
  2007-09-11 18:05 ` Andrew Lunn
  0 siblings, 1 reply; 2+ messages in thread
From: Sergei Gavrikov @ 2007-09-01 22:14 UTC (permalink / raw)
  To: eCos patches list

[-- Attachment #1: Type: text/plain, Size: 149 bytes --]

Add a function prototype to avoid compiler warning in dump_frame(), it
occurs when a CDL option CYGHWR_HAL_ARM_DUMP_EXCEPTIONS is selected.

	Sergei

[-- Attachment #2: hal_arm_arch_hal_misc.c.patch --]
[-- Type: text/x-diff, Size: 901 bytes --]

diff -ur hal/arm/arch/current/ChangeLog hal/arm/arch/current/ChangeLog.new
--- hal/arm/arch/current/ChangeLog
+++ hal/arm/arch/current/ChangeLog.new
@@ -1,3 +1,7 @@
+2007-09-02  Sergei Gavrikov  <sg@sgs.gomel.by>
+
+	* src/hal_misc.c: Add a function prototype to avoid warning.
+
 2007-02-03  Sergei Gavrikov  <sg@sgs.gomel.by>
 
 	* src/vectors.S: Added a possibility to fix ARM vector 0x14
diff -ur hal/arm/arch/current/src/hal_misc.c hal/arm/arch/current/src/hal_misc.c.new
--- hal/arm/arch/current/src/hal_misc.c
+++ hal/arm/arch/current/src/hal_misc.c.new
@@ -68,6 +68,7 @@
 #include <cyg/hal/hal_intr.h>           // HAL header
 
 externC void diag_printf(const char *fmt, ...);
+externC void diag_dump_buf(void *buf, CYG_ADDRWORD len);
 
 /*------------------------------------------------------------------------*/
 /* First level C exception handler.                                       */

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: hal/arm/acrh/hal_misc.c (fix warning)
  2007-09-01 22:14 hal/arm/acrh/hal_misc.c (fix warning) Sergei Gavrikov
@ 2007-09-11 18:05 ` Andrew Lunn
  0 siblings, 0 replies; 2+ messages in thread
From: Andrew Lunn @ 2007-09-11 18:05 UTC (permalink / raw)
  To: Sergei Gavrikov; +Cc: eCos patches list

[-- Attachment #1: Type: text/plain, Size: 352 bytes --]

On Sun, Sep 02, 2007 at 01:13:14AM +0300, Sergei Gavrikov wrote:
> Add a function prototype to avoid compiler warning in dump_frame(), it
> occurs when a CDL option CYGHWR_HAL_ARM_DUMP_EXCEPTIONS is selected.

Hi Sergei

Thanks for the patch. I decided instead to just include
<cyg/infra/diag.h> rather than had a prototype.

                   Andrew

[-- Attachment #2: hal_arm_arch.diff --]
[-- Type: text/x-diff, Size: 1449 bytes --]

Index: hal/arm/arch/current/ChangeLog
===================================================================
RCS file: /cvs/ecos/ecos/packages/hal/arm/arch/current/ChangeLog,v
retrieving revision 1.109
diff -u -r1.109 ChangeLog
--- hal/arm/arch/current/ChangeLog	4 Feb 2007 00:16:42 -0000	1.109
+++ hal/arm/arch/current/ChangeLog	11 Sep 2007 18:03:53 -0000
@@ -1,3 +1,9 @@
+2007-09-11  Andrew Lunn  <andrew.lunn@ascom.ch>
+
+	* src/hal_misc.c: Include <cyg/infra/diag.h> to prevent compiler
+	warning when CYGHWR_HAL_ARM_DUMP_EXCEPTIONS is enabled.
+	Reported by Sergei Gavrikov <w3sg@SoftHome.net.
+
 2007-02-03  Sergei Gavrikov  <sg@sgs.gomel.by>
 
 	* src/vectors.S: Added a possibility to fix ARM vector 0x14
Index: hal/arm/arch/current/src/hal_misc.c
===================================================================
RCS file: /cvs/ecos/ecos/packages/hal/arm/arch/current/src/hal_misc.c,v
retrieving revision 1.20
diff -u -r1.20 hal_misc.c
--- hal/arm/arch/current/src/hal_misc.c	24 May 2004 12:32:10 -0000	1.20
+++ hal/arm/arch/current/src/hal_misc.c	11 Sep 2007 18:03:53 -0000
@@ -67,7 +67,7 @@
 #include <cyg/hal/hal_arch.h>           // HAL header
 #include <cyg/hal/hal_intr.h>           // HAL header
 
-externC void diag_printf(const char *fmt, ...);
+#include <cyg/infra/diag.h>
 
 /*------------------------------------------------------------------------*/
 /* First level C exception handler.                                       */

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2007-09-11 18:05 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-09-01 22:14 hal/arm/acrh/hal_misc.c (fix warning) Sergei Gavrikov
2007-09-11 18:05 ` Andrew Lunn

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).