PPP: Negotiate both primary and secondary/alternative DNS resolvers

PPP: Negotiate both primary and secondary/alternative DNS resolvers

[Daniel Néri]

[-- Attachment #1: Type: text/plain, Size: 196 bytes --]

       Hello,

In the current sources, only the primary DNS resolver's address is
negotiated (RFC 1877) when CYGOPT_PPP_NS_NEGOTIATE is enabled. The
patch below fixes that.


Best wishes,
Daniel


[-- Attachment #2: Type: text/x-patch, Size: 1190 bytes --]

diff -Npru packages.552a89419756/net/ppp/current/ChangeLog packages.f24c28f4776a/net/ppp/current/ChangeLog
--- packages.552a89419756/net/ppp/current/ChangeLog	2008-04-28 13:35:09.000000000 +0200
+++ packages.f24c28f4776a/net/ppp/current/ChangeLog	2008-04-28 13:35:09.000000000 +0200
@@ -1,3 +1,8 @@
+2008-04-28  Daniel Néri  <daniel.neri@sigicom.com>
+
+	* src/ipcp.c (ipcp_init): Negotiate both primary and secondary DNS
+	resolver addresses when CYGOPT_PPP_NS_NEGOTIATE is enabled.
+
 2006-07-18  John Paul King  <john.king@transdatainc.com>
 
 	* src/sys-ecos.c (cyg_ppp_up): Bring semaphore init earlier to avoid
diff -Npru packages.552a89419756/net/ppp/current/src/ipcp.c packages.f24c28f4776a/net/ppp/current/src/ipcp.c
--- packages.552a89419756/net/ppp/current/src/ipcp.c	2008-04-28 13:35:09.000000000 +0200
+++ packages.f24c28f4776a/net/ppp/current/src/ipcp.c	2008-04-28 13:35:09.000000000 +0200
@@ -240,7 +240,8 @@ ipcp_init(unit)
     wo->default_route = ppp_tty.options->default_route;
 
 #ifdef CYGOPT_PPP_NS_NEGOTIATE
-    wo->neg_dns1 = 1;       
+    wo->neg_dns1 = 1;
+    wo->neg_dns2 = 1;
 #endif
 
     /* max slots and slot-id compression are currently hardwired in */

[-- Attachment #3: Type: text/plain, Size: 74 bytes --]


-- 
Daniel Néri <daniel.neri@sigicom.com>
Sigicom AB, Stockholm, Sweden

Re: PPP: Negotiate both primary and secondary/alternative DNS resolvers

[Andrew Lunn]

On Mon, Apr 28, 2008 at 01:53:23PM +0200, Daniel N?ri wrote:
>        Hello,
> 
> In the current sources, only the primary DNS resolver's address is
> negotiated (RFC 1877) when CYGOPT_PPP_NS_NEGOTIATE is enabled. The
> patch below fixes that.

Since the DNS resolver only supports one DNS server, what is this good for?

      Andrew

Re: PPP: Negotiate both primary and secondary/alternative DNS resolvers

[Daniel Néri]

Andrew Lunn <andrew@lunn.ch> writes:

> Since the DNS resolver only supports one DNS server, what is this good
> for?

I'm using another resolver, which supports multiple server addresses.

The secondary address is provided by cyg_ppp_get_neg_addrs, in the
"alt_dns" field of the cyg_ppp_neg_addrs_t struct. With the current
sources, that field never gets a value that's of any use.


Regards,
-- 
Daniel Néri <daniel.neri@sigicom.com>
Sigicom AB, Stockholm, Sweden

Re: PPP: Negotiate both primary and secondary/alternative DNS resolvers

[Andrew Lunn]

On Mon, Apr 28, 2008 at 01:53:23PM +0200, Daniel N?ri wrote:
>        Hello,
> 
> In the current sources, only the primary DNS resolver's address is
> negotiated (RFC 1877) when CYGOPT_PPP_NS_NEGOTIATE is enabled. The
> patch below fixes that.

Committed,
        Thanks
                Andrew