From: Andrew Lunn <andrew@lunn.ch>
To: Sergei Gavrikov <sergei.gavrikov@gmail.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
eCos patches list <ecos-patches@ecos.sourceware.org>
Subject: Re: Support for Olimex LPC-H2294, LPC-E2294, LPC-L2294-1M targets
Date: Sun, 23 Nov 2008 13:29:00 -0000 [thread overview]
Message-ID: <20081123132741.GT17925@lunn.ch> (raw)
In-Reply-To: <20081123124841.GA15719@ubuntu.local>
[-- Attachment #1: Type: text/plain, Size: 783 bytes --]
On Sun, Nov 23, 2008 at 02:48:41PM +0200, Sergei Gavrikov wrote:
> On Sun, Nov 23, 2008 at 02:39:42PM +0200, Sergei Gavrikov wrote:
> > On Sun, Nov 23, 2008 at 01:16:30PM +0100, Andrew Lunn wrote:
> > > Here is the first issue i found when compile testing.
> > >
> > > The olpch2294 target includes
> > > CYGPKG_DEVICES_WATCHDOG_ARM_LPC2XXX. However when you include the
> > > generic watchdog package you get:
> > [snip]
> > > It seems like the other targets have the same problem as well.
> >
> > Hi, I ponted on that in past:
> > http://sourceware.org/ml/ecos-discuss/2008-09/msg00038.html
> >
> > It seems that was not been applied.
The patch in the archive did not compile either. This is the patch i
committed. Please can you test it.
Thanks
Andrew
[-- Attachment #2: devs_watchdog_arm_lpc2xxx.diff --]
[-- Type: text/x-diff, Size: 1605 bytes --]
Index: devs/watchdog/arm/lpc2xxx/current/ChangeLog
===================================================================
RCS file: /cvs/ecos/ecos/packages/devs/watchdog/arm/lpc2xxx/current/ChangeLog,v
retrieving revision 1.3
diff -u -r1.3 ChangeLog
--- devs/watchdog/arm/lpc2xxx/current/ChangeLog 4 Sep 2008 05:39:42 -0000 1.3
+++ devs/watchdog/arm/lpc2xxx/current/ChangeLog 23 Nov 2008 13:25:41 -0000
@@ -1,3 +1,9 @@
+2008-11-23 Sergei Gavrikov <sergei.gavrikov@gmail.com>
+ Andrew Lunn <andrew@lunn.ch>
+
+ * src/watchdog_lpc2xxx.cxx: Since CYG_HAL_ARM_LPC2XXX_PCLK()
+ macro has been removed from lpc2xxx_misc.h, insert a definition here.
+
2008-09-03 Sergei Gavrikov <sergei.gavrikov@gmail.com>
* src/watchdog_lpc2xxx.cxx: Since CYG_HAL_ARM_LPC2XXX_PCLK()
Index: devs/watchdog/arm/lpc2xxx/current/src/watchdog_lpc2xxx.cxx
===================================================================
RCS file: /cvs/ecos/ecos/packages/devs/watchdog/arm/lpc2xxx/current/src/watchdog_lpc2xxx.cxx,v
retrieving revision 1.3
diff -u -r1.3 watchdog_lpc2xxx.cxx
--- devs/watchdog/arm/lpc2xxx/current/src/watchdog_lpc2xxx.cxx 4 Sep 2008 05:39:42 -0000 1.3
+++ devs/watchdog/arm/lpc2xxx/current/src/watchdog_lpc2xxx.cxx 23 Nov 2008 13:25:41 -0000
@@ -71,7 +71,7 @@
//==========================================================================
-#define TICKS (CYGHAL_ARM_LPC2XXX_PCLK/4000 * \
+#define TICKS (CYGNUM_HAL_ARM_LPC2XXX_PCLK/4000 * \
CYGNUM_DEVS_WATCHDOG_ARM_LPC2XXX_DESIRED_TIMEOUT_MS)
#define RESOLUTION CYGNUM_DEVS_WATCHDOG_ARM_LPC2XXX_DESIRED_TIMEOUT_MS*1000000
next prev parent reply other threads:[~2008-11-23 13:29 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-03 20:55 Sergei Gavrikov
2008-11-07 18:30 ` Sergei Gavrikov
2008-11-20 20:22 ` Andrew Lunn
2008-11-20 20:48 ` Sergei Gavrikov
2008-11-20 21:58 ` Andrew Lunn
2008-11-21 2:28 ` Sergei Gavrikov
2008-11-22 19:50 ` Sergei Gavrikov
2008-11-23 12:17 ` Andrew Lunn
2008-11-23 12:40 ` Sergei Gavrikov
2008-11-23 12:49 ` Sergei Gavrikov
2008-11-23 13:00 ` Andrew Lunn
2008-11-23 13:06 ` Sergei Gavrikov
2008-11-23 13:29 ` Andrew Lunn [this message]
2008-11-23 13:43 ` Sergei Gavrikov
2008-11-23 13:46 ` Andrew Lunn
2008-11-23 14:03 ` Sergei Gavrikov
2008-11-23 14:34 ` Andrew Lunn
2008-11-23 13:31 ` Andrew Lunn
2008-11-23 16:07 ` Sergei Gavrikov
2008-11-30 9:42 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081123132741.GT17925@lunn.ch \
--to=andrew@lunn.ch \
--cc=ecos-patches@ecos.sourceware.org \
--cc=sergei.gavrikov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).