From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29698 invoked by alias); 2 Dec 2008 10:57:07 -0000 Received: (qmail 29688 invoked by uid 22791); 2 Dec 2008 10:57:06 -0000 X-Spam-Level: * X-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from ug-out-1314.google.com (HELO ug-out-1314.google.com) (66.249.92.172) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 02 Dec 2008 10:56:27 +0000 Received: by ug-out-1314.google.com with SMTP id m2so2966777ugc.30 for ; Tue, 02 Dec 2008 02:56:24 -0800 (PST) Received: by 10.210.56.7 with SMTP id e7mr13846023eba.32.1228215384037; Tue, 02 Dec 2008 02:56:24 -0800 (PST) Received: from smtp.gmail.com ([82.209.212.146]) by mx.google.com with ESMTPS id q9sm7993780gve.6.2008.12.02.02.56.18 (version=TLSv1/SSLv3 cipher=RC4-MD5); Tue, 02 Dec 2008 02:56:22 -0800 (PST) Date: Tue, 02 Dec 2008 10:57:00 -0000 To: Andrew Lunn Cc: Sergei Gavrikov , eCos patches list Subject: Re: flash_olpcx2294_v2 package Message-ID: <20081202105915.GA16365@sg-ubuntu.local> References: <20081130122309.GA15263@ubuntu.local> <20081130124943.GA16517@ubuntu.local> <20081202061808.GL27015@lunn.ch> <20081202065654.GB8635@sg-ubuntu.local> <20081202072624.GA10204@sg-ubuntu.local> <20081202072943.GB9050@lunn.ch> <20081202080107.GA11841@sg-ubuntu.local> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="HlL+5n6rz5pIUxbD" Content-Disposition: inline In-Reply-To: <20081202080107.GA11841@sg-ubuntu.local> User-Agent: Mutt/1.5.13 (2006-08-11) From: Sergei Gavrikov X-Virus-Checked: Checked by ClamAV on sourceware.org Mailing-List: contact ecos-patches-help@ecos.sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: ecos-patches-owner@ecos.sourceware.org X-SW-Source: 2008-12/txt/msg00007.txt.bz2 --HlL+5n6rz5pIUxbD Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-length: 766 Sergei Gavrikov wrote: > On Tue, Dec 02, 2008 at 08:29:43AM +0100, Andrew Lunn wrote: > > > ..Hm, and this morning it seemed for me that the best place would be > > > var_arch.h. lpc2xxx's var_io.h has a lot of defines and those in mainly > > > are I/O macros. IMHO, memory access is something another, isn't it? If > > > my morning opinion is right, a patch is provided. > > > > You are using these macros for memory mapped IO. So var_io.h seems > > correct to me. However, as the find(1) showed, there is no 100% > > correct answer. > > Thank you for a feedback. I fully trust your experience. As you suggest > it placed in a right place and there are ifdef there. I'm sorry, quick patching break things. There was 1 #ifndef without argument :-( Fixed. Sergei --HlL+5n6rz5pIUxbD Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="lpc2xxx_var.diff" Content-length: 2061 Index: hal/arm/lpc2xxx/var/current/ChangeLog =================================================================== RCS file: /cvs/ecos/ecos/packages/hal/arm/lpc2xxx/var/current/ChangeLog,v retrieving revision 1.9 diff -u -5 -r1.9 ChangeLog --- hal/arm/lpc2xxx/var/current/ChangeLog 22 Jul 2008 18:52:16 -0000 1.9 +++ hal/arm/lpc2xxx/var/current/ChangeLog 2 Dec 2008 07:52:38 -0000 @@ -1,5 +1,10 @@ +2008-12-02 Sergei Gavrikov + Andrew Lunn + + * include/var_io.h: Memory access macros added. + 2008-07-21 Uwe Kindler * cdl/hal_arm_lpc2xxx.cdl: Added option CYGHWR_HAL_ARM_LPC2XXX_VARIANT_VERSION to identify the variant version because some on-chip peripherals changed slightly in newer veriants. Index: hal/arm/lpc2xxx/var/current/include/var_io.h =================================================================== RCS file: /cvs/ecos/ecos/packages/hal/arm/lpc2xxx/var/current/include/var_io.h,v retrieving revision 1.2 diff -u -5 -r1.2 var_io.h --- hal/arm/lpc2xxx/var/current/include/var_io.h 7 May 2006 18:36:18 -0000 1.2 +++ hal/arm/lpc2xxx/var/current/include/var_io.h 2 Dec 2008 07:52:38 -0000 @@ -52,10 +52,26 @@ #include // variant chip model selection. #include //============================================================================= +// Memory access macros + +#ifndef CYGARC_CACHED_ADDRESS +# define CYGARC_CACHED_ADDRESS(x) (x) +#endif +#ifndef CYGARC_UNCACHED_ADDRESS +# define CYGARC_UNCACHED_ADDRESS(x) (x) +#endif +#ifndef CYGARC_PHYSICAL_ADDRESS +# define CYGARC_PHYSICAL_ADDRESS(x) (x) +#endif +#ifndef CYGARC_VIRTUAL_ADDRESS +# define CYGARC_VIRTUAL_ADDRESS(x) (x) +#endif + +//============================================================================= // Watchdog (WD) #define CYGARC_HAL_LPC2XXX_REG_WD_BASE 0xE0000000 // Registers are offsets from base of this subsystem --HlL+5n6rz5pIUxbD--