From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11858 invoked by alias); 21 Nov 2010 21:50:21 -0000 Received: (qmail 11826 invoked by uid 22791); 21 Nov 2010 21:50:17 -0000 X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from hagrid.ecoscentric.com (HELO mail.ecoscentric.com) (212.13.207.197) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 21 Nov 2010 21:50:10 +0000 Received: from localhost (hagrid.ecoscentric.com [127.0.0.1]) by mail.ecoscentric.com (Postfix) with ESMTP id D59BB2F7800C for ; Sun, 21 Nov 2010 21:50:07 +0000 (GMT) Received: from mail.ecoscentric.com ([127.0.0.1]) by localhost (hagrid.ecoscentric.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id c6B27k6s4RVA; Sun, 21 Nov 2010 21:50:06 +0000 (GMT) From: bugzilla-daemon@bugs.ecos.sourceware.org To: ecos-patches@sourceware.org Subject: Patch_or_Contribution granted: [Bug 1001078] STM32 flash driver support for non-aligned source buffers. X-Bugzilla-Type: request In-Reply-To: References: X-Bugzilla-URL: http://bugs.ecos.sourceware.org/ Auto-Submitted: auto-generated Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Date: Sun, 21 Nov 2010 21:50:00 -0000 Message-Id: <20101121215006.A8ABE2F78003@mail.ecoscentric.com> Mailing-List: contact ecos-patches-help@ecos.sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: ecos-patches-owner@ecos.sourceware.org X-SW-Source: 2010-11/txt/msg00021.txt.bz2 Jonathan Larmour has granted Patch_or_Contribution: Bug 1001078: STM32 flash driver support for non-aligned source buffers. http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001078 ------- Additional Comments from Jonathan Larmour I'm not keen on this patch I'm afraid. The other drivers (e.g. AM29xxxxxv2, stratav2) have the same constraints and intentionally enforce alignment. I don't want to go down the route of people expecting unaligned data to be ok (and then they'd be likely to claim it is a "bug" for unaligned data not to be accepted by any driver). That said, I wouldn't have a problem with this being a driver-specific CDL option if you wanted to rework it on those lines, if you're keen. The length alignment check is reasonable in any case of course.