From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23863 invoked by alias); 18 Jan 2011 01:48:35 -0000 Received: (qmail 23712 invoked by uid 22791); 18 Jan 2011 01:48:33 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from hagrid.ecoscentric.com (HELO mail.ecoscentric.com) (212.13.207.197) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 18 Jan 2011 01:48:29 +0000 Received: from localhost (hagrid.ecoscentric.com [127.0.0.1]) by mail.ecoscentric.com (Postfix) with ESMTP id B64833370374 for ; Tue, 18 Jan 2011 01:48:26 +0000 (GMT) Received: from mail.ecoscentric.com ([127.0.0.1]) by localhost (hagrid.ecoscentric.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id K3xuOBkp+y4U; Tue, 18 Jan 2011 01:48:22 +0000 (GMT) From: bugzilla-daemon@bugs.ecos.sourceware.org To: ecos-patches@ecos.sourceware.org Subject: [Bug 1001114] New port: NXP LPC17XX Variant, Olimex LPC-1766-STK platform X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: eCos X-Bugzilla-Component: Patches and contributions X-Bugzilla-Keywords: X-Bugzilla-Severity: enhancement X-Bugzilla-Who: ilijak@siva.com.mk X-Bugzilla-Status: UNCONFIRMED X-Bugzilla-Priority: low X-Bugzilla-Assigned-To: unassigned@bugs.ecos.sourceware.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Changed-Fields: In-Reply-To: References: X-Bugzilla-URL: http://bugs.ecos.sourceware.org/ Auto-Submitted: auto-generated Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Date: Tue, 18 Jan 2011 01:48:00 -0000 Message-Id: <20110118014821.D828E2F80002@mail.ecoscentric.com> Mailing-List: contact ecos-patches-help@ecos.sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: ecos-patches-owner@ecos.sourceware.org X-SW-Source: 2011-01/txt/msg00033.txt.bz2 Please do not reply to this email. Use the web interface provided at: http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001114 --- Comment #8 from Ilija Kocho 2011-01-18 01:48:19 GMT --- (In reply to comment #6) > Hi, > > First, Ilija, thank you for your contribution. Thanks for the review Sergei. > > [RFC to reviewers] > > As NXP does "copy and paste" own "PrimeCell" registers from a design > to design (what is generally speaking is good for programmers) we can > observe the same interference the device drivers in a code each other > (e.g. lpc2xxx, lpc24xx and now lpc17xx). New Ilija's port for lpc17xx is > a good example such an interference and how the hackers would deal with > "PrimeCell" registers to reuse the code. > [snip] > > Pros: code reuse, code reuse, code reuse. > [snip] > Cons: code interference, "difficult" to understand HAL, the bloches of > "foreigners" in the target definition (see attachment 1078 [details]). > [snip] > Well, I see new "Cons" in my proposal: code duplication, code duplication, > code duplication :-) Maybe someone found a better solution? And maybe > my fears are baseless at all? Then forget it, please. Sergei I had the same dilemma but I found out that peripherals are so compatible, eCos so well structured and Uwe's (and other's) work so good that coupling LPC42xx drivers with LPC17xx went with very little intervention from my side - they love each other. I merely introduced them by submitting LPC17xx base addresses. And I think in this case it pays off and should be considered for other peripherals. One point: please note that the real UART work is done by generic 16x5x driver that is shared among myriad of devices and architectures. I did the opposite for HAL diagnostic drivers by grafting LPC24xx code onto STM32 template (and taking the credits :) ). -- Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.