From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2641 invoked by alias); 26 Jan 2011 20:15:09 -0000 Received: (qmail 2355 invoked by uid 22791); 26 Jan 2011 20:15:07 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from hagrid.ecoscentric.com (HELO mail.ecoscentric.com) (212.13.207.197) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 26 Jan 2011 20:15:02 +0000 Received: from localhost (hagrid.ecoscentric.com [127.0.0.1]) by mail.ecoscentric.com (Postfix) with ESMTP id AED843370403 for ; Wed, 26 Jan 2011 20:14:59 +0000 (GMT) Received: from mail.ecoscentric.com ([127.0.0.1]) by localhost (hagrid.ecoscentric.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id J19gtji7O7eY; Wed, 26 Jan 2011 20:14:58 +0000 (GMT) From: bugzilla-daemon@bugs.ecos.sourceware.org To: ecos-patches@ecos.sourceware.org Subject: [Bug 1001116] Instruct lwIP to use special section for buffers and heap. X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: eCos X-Bugzilla-Component: Patches and contributions X-Bugzilla-Keywords: X-Bugzilla-Severity: enhancement X-Bugzilla-Who: ilijak@siva.com.mk X-Bugzilla-Status: UNCONFIRMED X-Bugzilla-Priority: low X-Bugzilla-Assigned-To: unassigned@bugs.ecos.sourceware.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Changed-Fields: In-Reply-To: References: X-Bugzilla-URL: http://bugs.ecos.sourceware.org/ Auto-Submitted: auto-generated Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Date: Wed, 26 Jan 2011 20:15:00 -0000 Message-Id: <20110126201458.2E6E82F80002@mail.ecoscentric.com> Mailing-List: contact ecos-patches-help@ecos.sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: ecos-patches-owner@ecos.sourceware.org X-SW-Source: 2011-01/txt/msg00067.txt.bz2 Please do not reply to this email. Use the web interface provided at: http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001116 --- Comment #8 from Ilija Kocho 2011-01-26 20:14:56 GMT --- (In reply to comment #7) > Ilia, IMO, new CDL entries in Attachment 1094 [details] look too complex. As far as I > could understand you should manage only MEM_SECTION definition. May be to use > something more simple in lwip_net.cdl, like below (alone option): > > cdl_option CYGOPT_LWIP_MEM_SPEC_SECTION { > display "Use specified section" > requires CYGINT_LWIP_MEM_SECTIONING > active_if CYGIMP_LWIP_MEM_ATTR_SECTION > default_value 0 > } > > It requires one interface CYGINT_LWIP_MEM_SECTIONING which can be implemented > in HAL (so, the option is active if that is implemented > CYGIMP_LWIP_MEM_ATTR_SECTION will be true). It's much simpler indeed Sergei. Below is a implementation based on your suggestion. It uses booldata in lwip_net.cdl that is also used for concatenation. We need concatenation because the supplied by HAL is a stem not only for section attribute, but also for section boundaries ___start, ___end provided by ld. CYGDAT_LWIP_MEM_SECTION should be considered in conjunction with Attachment http://bugs.ecos.sourceware.org/attachment.cgi?id=1088 to Bug 1001114 (macros SECTION_START() and SECTION_END()). Here is the code for review: ---- lwip_net.cdl -------------------------------------------------------------- cdl_option CYGDAT_LWIP_MEM_SECTION { display "Special memory section for lwIP buffers" active_if CYGDAT_LWIP_MEM_SECTION_NAME requires CYGDAT_LWIP_MEM_SECTION_NAME flavor booldata calculated { "\"." . CYGDAT_LWIP_MEM_SECTION_NAME . "\""} description "If enabled, this option will use specified memory section for lwip-tcp p-buffers and heap. The section name is typically provided by HAL. Dependent on platform this may utilize additional memory resources." } ---- hal_cortexm_lpc17xx_lpc1766stk.cdl ---------------------------------------- cdl_option CYGDAT_LWIP_MEM_SECTION_NAME { flavor booldata active_if CYGPKG_NET_LWIP parent CYGOPT_LWIP_MEM_PLF_SPEC default_value { "ahb_bss" } display "Use this memory section for lwIP data." description "Enable special section for lwIP data and provide section name." } ---- lwipopts.h ---------------------------------------------------------------- #ifdef CYGDAT_LWIP_MEM_SECTION #include #define MEM_SECTION CYGBLD_ATTRIB_SECTION(CYGDAT_LWIP_MEM_SECTION) #else #define MEM_SECTION #endif -- Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.