From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23498 invoked by alias); 29 Jan 2011 14:54:23 -0000 Received: (qmail 23472 invoked by uid 22791); 29 Jan 2011 14:54:22 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from hagrid.ecoscentric.com (HELO mail.ecoscentric.com) (212.13.207.197) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 29 Jan 2011 14:54:15 +0000 Received: from localhost (hagrid.ecoscentric.com [127.0.0.1]) by mail.ecoscentric.com (Postfix) with ESMTP id 642272F7800A for ; Sat, 29 Jan 2011 14:54:13 +0000 (GMT) Received: from mail.ecoscentric.com ([127.0.0.1]) by localhost (hagrid.ecoscentric.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id wM2FA+m+JVLM; Sat, 29 Jan 2011 14:54:11 +0000 (GMT) From: bugzilla-daemon@bugs.ecos.sourceware.org To: ecos-patches@ecos.sourceware.org Subject: [Bug 1001116] Instruct lwIP to use special section for buffers and heap. X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: eCos X-Bugzilla-Component: Patches and contributions X-Bugzilla-Keywords: X-Bugzilla-Severity: enhancement X-Bugzilla-Who: sergei.gavrikov@gmail.com X-Bugzilla-Status: UNCONFIRMED X-Bugzilla-Priority: low X-Bugzilla-Assigned-To: unassigned@bugs.ecos.sourceware.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Changed-Fields: In-Reply-To: References: X-Bugzilla-URL: http://bugs.ecos.sourceware.org/ Auto-Submitted: auto-generated Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Date: Sat, 29 Jan 2011 14:54:00 -0000 Message-Id: <20110129145411.A6B642F78001@mail.ecoscentric.com> Mailing-List: contact ecos-patches-help@ecos.sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: ecos-patches-owner@ecos.sourceware.org X-SW-Source: 2011-01/txt/msg00074.txt.bz2 Please do not reply to this email. Use the web interface provided at: http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001116 --- Comment #13 from Sergei Gavrikov 2011-01-29 14:54:09 GMT --- Hi So far it is about the below, (In reply to comment #12) > (In reply to comment #11) [snip] > > ... that can be > > > > cdl_package CYGPKG_NET_LWIP { > > ... > > cdl_option CYGSEM_LWIP_MEM_SECTION { > > display "Relocate memory pools" > > flavor bool > > calculated is_active(CYGDAT_LWIP_MEM_SECTION_NAME) > > ... > > } > > } > > > > Wouldn't it be clearer in configtool if CYGSEM_LWIP_MEM_SECTION is "grayed" > when we have no memory section provided? > Hence active_if CYGDAT_LWIP_MEM_SECTION_NAME Agreed. I vote for a full control and no mess (gray for the most cases): cdl_option CYGSEM_LWIP_MEM_SECTION { ... flavor bool default_value 0 active_if CYGDAT_LWIP_MEM_SECTION_NAME ... } No calculate, no guess, the last word for a user! Even if her/his target provides *_SECTION_NAME, he/she should decide use the feature or not. [snip] > Also there is one point for further discussion: > - Concatenation or plain strings? I prefer the plain strings. > IMO it would depend on resolution for section related macros proposed in > http://bugs.ecos.sourceware.org/attachment.cgi?id=1088 to Bug 1001114 . > > For reference, here is a digest of all code snippets as are in my current > build: > ----------------- > cdl_package CYGPKG_NET_LWIP { > ... > cdl_option CYGDAT_LWIP_MEM_SECTION { > display "Special memory section for lwIP buffers." > active_if CYGDAT_LWIP_MEM_SECTION_NAME > requires CYGDAT_LWIP_MEM_SECTION_NAME > flavor data > calculated { "\"." . CYGDAT_LWIP_MEM_SECTION_NAME . "\"" } > description "..." > } > ... > } I dislike the above as the most users will be to see in CT a strange grayed data box like below: - |__) Momory options [ab] "Special memory section for lwIP buffers." | ".0" What's that ".0"? That's concatenation with an absent data. Be continue. Thanks, Sergei -- Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.