From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23651 invoked by alias); 30 Jan 2011 11:50:14 -0000 Received: (qmail 23599 invoked by uid 22791); 30 Jan 2011 11:50:12 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from hagrid.ecoscentric.com (HELO mail.ecoscentric.com) (212.13.207.197) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 30 Jan 2011 11:50:07 +0000 Received: from localhost (hagrid.ecoscentric.com [127.0.0.1]) by mail.ecoscentric.com (Postfix) with ESMTP id 66E1F3370486 for ; Sun, 30 Jan 2011 11:50:05 +0000 (GMT) Received: from mail.ecoscentric.com ([127.0.0.1]) by localhost (hagrid.ecoscentric.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id u1OozpY9Mw8P; Sun, 30 Jan 2011 11:49:48 +0000 (GMT) From: bugzilla-daemon@bugs.ecos.sourceware.org To: ecos-patches@ecos.sourceware.org Subject: [Bug 1001116] Instruct lwIP to use special section for buffers and heap. X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: eCos X-Bugzilla-Component: Patches and contributions X-Bugzilla-Keywords: X-Bugzilla-Severity: enhancement X-Bugzilla-Who: ilijak@siva.com.mk X-Bugzilla-Status: UNCONFIRMED X-Bugzilla-Priority: low X-Bugzilla-Assigned-To: unassigned@bugs.ecos.sourceware.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Changed-Fields: In-Reply-To: References: X-Bugzilla-URL: http://bugs.ecos.sourceware.org/ Auto-Submitted: auto-generated Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Date: Sun, 30 Jan 2011 11:50:00 -0000 Message-Id: <20110130114947.CB9682F80002@mail.ecoscentric.com> Mailing-List: contact ecos-patches-help@ecos.sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: ecos-patches-owner@ecos.sourceware.org X-SW-Source: 2011-01/txt/msg00079.txt.bz2 Please do not reply to this email. Use the web interface provided at: http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001116 --- Comment #18 from Ilija Kocho 2011-01-30 11:49:45 GMT --- (In reply to comment #17) > Created an attachment (id=1107) --> (http://bugs.ecos.sourceware.org/attachment.cgi?id=1107) [details] > lwip_tcpip: Enter MEM_SECTION entity > > Ilija, here is a patch which makes obsolete Attachment 1094 [details]. Build was tested > for one ARM target, to simplify testing I used ".2ram.lwip" section attribute: > cdl_configuration eCos { > template lwip_eth ; > }; > cdl_option CYGOPT_LWIP_MEM_SECTION { > user_value 1 > }; > cdl_option CYGDAT_LWIP_MEM_SECTION_NAME { > user_value "\".2ram.lwip\"" > }; > > If this patch is suitable for you, let me know, please, and I will commit it. Sergei thanks for your consideration, we're getting closer. I have little experience with ECM and i find it as a very powerful mechanism but i AFAIK unfortunately there is not a way for automatic import (someting like import or include statement in CDL). IMO this may be inconvenient for configtool users as it requires extra clicking. Therefore i would prefer something that will not depend on ECM. One way is: cdl_option CYGOPT_LWIP_MEM_SECTION { ... default_value 1 ... } If CYGDAT_LWIP_MEM_SECTION_NAME is active than recommended action will be to use it. If not active, then CYGSEM_LWIP_MEM_SECTION is grey and it's value is irrelevant. As a consequence lwipopts.h shall change accordingly: #if defined(CYGOPT_LWIP_MEM_SECTION) && CYGOPT_LWIP_MEM_SECTION #include # define MEM_SECTION CYGBLD_ATTRIB_SECTION(CYGDAT_LWIP_MEM_SECTION_NAME) #else # define MEM_SECTION #endif Earlier this morning I did some tests with former combination and i was about to post when I got Mid-air collision. Below is my test case for reference and review. Please comment. --- lwip_net.cdl --- cdl_option CYGSEM_LWIP_MEM_SECTION { display "Place lwIP buffers and heap in special memory section." flavor bool default_value 1 active_if CYGDAT_LWIP_MEM_SECTION_NAME description "..." } --- lwipopts.h --- #if defined(CYGSEM_LWIP_MEM_SECTION) && CYGSEM_LWIP_MEM_SECTION #include #define MEM_SECTION CYGBLD_ATTRIB_SECTION(CYGDAT_LWIP_MEM_SECTION_NAME) #else #define MEM_SECTION #endif --- hal...cdl --- cdl_option CYGDAT_LWIP_MEM_SECTION_NAME { flavor data active_if CYGPKG_NET_LWIP parent CYGOPT_LWIP_MEM_PLF_SPEC default_value { "\".foo\"" } legal_values { "\".foo\"" "\".bar\"" } display "Memory section for lwIP buffers." description " ... " } --------- -- Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.