From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11033 invoked by alias); 9 Feb 2011 01:25:54 -0000 Received: (qmail 11005 invoked by uid 22791); 9 Feb 2011 01:25:53 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from hagrid.ecoscentric.com (HELO mail.ecoscentric.com) (212.13.207.197) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 09 Feb 2011 01:25:49 +0000 Received: from localhost (hagrid.ecoscentric.com [127.0.0.1]) by mail.ecoscentric.com (Postfix) with ESMTP id 067F82F7800D for ; Wed, 9 Feb 2011 01:25:47 +0000 (GMT) Received: from mail.ecoscentric.com ([127.0.0.1]) by localhost (hagrid.ecoscentric.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id zb5qu2AcB3Eu; Wed, 9 Feb 2011 01:25:45 +0000 (GMT) From: bugzilla-daemon@bugs.ecos.sourceware.org To: ecos-patches@sourceware.org Subject: Patch_or_Contribution granted: [Bug 1001125] New HAL for the Stellaris EK-LM3S811 board X-Bugzilla-Type: request In-Reply-To: References: X-Bugzilla-URL: http://bugs.ecos.sourceware.org/ Auto-Submitted: auto-generated Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Date: Wed, 09 Feb 2011 01:25:00 -0000 Message-Id: <20110209012544.83C082F78004@mail.ecoscentric.com> Mailing-List: contact ecos-patches-help@ecos.sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: ecos-patches-owner@ecos.sourceware.org X-SW-Source: 2011-02/txt/msg00022.txt.bz2 Jonathan Larmour has granted Patch_or_Contribution: Bug 1001125: New HAL for the Stellaris EK-LM3S811 board http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001125 ------- Additional Comments from Jonathan Larmour I've scanned through the patches and nothing major has leapt out at me. My only comments are essentially cosmetic: You don't need the memory segments if there's only one of them, and indeed you have (correctly) not defined CYGBLD_REDBOOT_MAX_MEM_SEGMENTS. And RedBoot probably will never be supported anyway. So that function can just go away. The HAL_VAR_INTERRUPT_* macros should go - if they're not defined, the code in the arch HAL which uses them should do the right thing. And utterly trivial: the default_ROM.ecm has "template default" in it. Your documentation uses the minimal template, not default, so by rights the .ecm should have "template minimal". I don't know about anyone else, but I look at the template line of .ecm files to see what template this .ecm should be applied to. All in all, it's a very good quality patch. Thanks! Jifl