From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28415 invoked by alias); 6 Mar 2011 18:29:03 -0000 Received: (qmail 28360 invoked by uid 22791); 6 Mar 2011 18:29:01 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from hagrid.ecoscentric.com (HELO mail.ecoscentric.com) (212.13.207.197) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 06 Mar 2011 18:28:56 +0000 Received: from localhost (hagrid.ecoscentric.com [127.0.0.1]) by mail.ecoscentric.com (Postfix) with ESMTP id AE9B92F80004 for ; Sun, 6 Mar 2011 18:28:53 +0000 (GMT) Received: from mail.ecoscentric.com ([127.0.0.1]) by localhost (hagrid.ecoscentric.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id OS1nX-tov5RC; Sun, 6 Mar 2011 18:28:52 +0000 (GMT) From: bugzilla-daemon@bugs.ecos.sourceware.org To: ecos-patches@ecos.sourceware.org Subject: [Bug 1001114] New port: NXP LPC17XX Variant, Olimex LPC-1766-STK platform X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: eCos X-Bugzilla-Component: Patches and contributions X-Bugzilla-Keywords: X-Bugzilla-Severity: enhancement X-Bugzilla-Who: sergei.gavrikov@gmail.com X-Bugzilla-Status: UNCONFIRMED X-Bugzilla-Priority: low X-Bugzilla-Assigned-To: unassigned@bugs.ecos.sourceware.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Changed-Fields: In-Reply-To: References: X-Bugzilla-URL: http://bugs.ecos.sourceware.org/ Auto-Submitted: auto-generated Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Date: Sun, 06 Mar 2011 18:29:00 -0000 Message-Id: <20110306182852.100042F78005@mail.ecoscentric.com> Mailing-List: contact ecos-patches-help@ecos.sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: ecos-patches-owner@ecos.sourceware.org X-SW-Source: 2011-03/txt/msg00001.txt.bz2 Please do not reply to this email. Use the web interface provided at: http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001114 --- Comment #28 from Sergei Gavrikov 2011-03-06 18:28:40 GMT --- (In reply to comment #27) Hi, > Now here I submit correction of my bugs. This patch is incremental. Ilija, thank you for your clean-ups. > Fixes: > > 1) Now is tested with RedBoot too. Previously had forgotten to synchronize > memory region list for RedBoot after i renamed memory regions. > Question: How much useful is RedBoot on these particular chips. IMO, even if user cannot use RedBoot as a debug infra for the target, it is great always to have an ability to build ROM monitor and try it. So, thank you. > 2) Other changes are a monkey work, I tried to follow you in inactivation of > non implemented stuff. I also re-introduce comments on enabled IO port pins, > I hope now they are more descriptive: > // Enable pins: TXD1. .. .. .. .. .. RXD0-TXD0 .. > // Enable pins: .. .. .. .. .RTS1 .DTR1 DSR1-DCD1 CTS1-RXD1 > where dots (.) stand for non-enabled pins while names represent selected pin > functionality. Dot's/names are in pairs according to LPC PINSEL register > organization. > Anyway if you think they're not good enough you can remove them. I get it (however, it looks a bit encrypted :-). I have doubts about the "modem" signals which were turned on by default. Do you really need to activate them in the statrup code? About comments-memo, I would prefer to have (diff against your delta) - // Enable UART0 and UART1 pins - - // Enable pins: TXD1. .. .. .. .. .. RXD0-TXD0 .. - CYGHWR_HAL_LPC17XX_PIN_SET(CYGHWR_HAL_LPC17XX_REG_PINSEL0, 0x40000050); - - // Enable pins: .. .. .. .. .RTS1 .DTR1 DSR1-DCD1 CTS1-RXD1 - CYGHWR_HAL_LPC17XX_PIN_SET(CYGHWR_HAL_LPC17XX_REG_PINSEL1, 0x00001155); - + // Enable UART0 and UART1 + CYGHWR_HAL_LPC17XX_PIN_SET(CYGHWR_HAL_LPC17XX_REG_PINSEL0, + (1 /* TXD0 */ << 4) | + (1 /* RXD0 */ << 6) | + (1 /* TXD1 */ << 30) + ); + CYGHWR_HAL_LPC17XX_PIN_SET(CYGHWR_HAL_LPC17XX_REG_PINSEL1, + (1 /* RXD1 */ << 0) + ); But, maybe someone will have alternative view (about "modem" signals). -- Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.